Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tax Forms work as "read-only" with Reaction v3.1.0 #216

Closed
kieckhafer opened this issue Feb 13, 2020 · 0 comments
Closed

Tax Forms work as "read-only" with Reaction v3.1.0 #216

kieckhafer opened this issue Feb 13, 2020 · 0 comments
Assignees
Milestone

Comments

@kieckhafer
Copy link
Member

kieckhafer commented Feb 13, 2020

Issue Description

With the release of Reaction API v3.1.0, the tax forms on variants no longer work to update tax rates. They still display the correct data, and update correctly when using the taxRate mutations directly.

Steps to Reproduce

Please provide starting context, i.e. logged in as a user, configure a particular payment method.

  1. Create a product
  2. See that the tax rates on variants update correctly if using the mutation via GraphiQL
  3. See that the form shows the updated version, but you can't update the tax rate from the form itself, you'll see this error:
03:12:06.945Z  INFO Reaction: Primary tax service calculation returned null. Using set fallback tax service

Possible Solution

Update the forms to use the GQL mutation when updating the rates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants