-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add full GQL support to product editor #188
Conversation
671dbf5
to
f7fa37f
Compare
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
@willopez Ok... This is enough for this PR. The editor still needs some work, especially to the media gallery block, but for the most part, everything is in place and seems to work. I'd like to push any non-critical feedback into a fresh PR. One issue, in particular, would be with the Media Gallery editor. I've put those issues into this ticket: #236 |
@mikemurray When changes are saved and the updated Product is returned, After a page reload the changes are visible, ot by doing a second change in order to get a new refetch. That state would be old again: Might need api changes to correctly deliver a new hash directly upon change, or else, an artifical delay like for images. |
The TagSelector Component needs As this is broken in the catalyst library, one option is to define a custom theme override in the admin's theme: Certainly better to fix this in catalyst. |
@janus-reith MUI Dialog: I agree, probably best to fix the default in Catalyst. |
@janus-reith Just checked, and yes, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving so that we can merge this and start fixing issues on new PRs. The issues found are in issue #237.
Resolves #168 #184 #212 #216 #220 #223
Impact: major
Type: feature|refactor
Issue
There are many issues with the current meteor specific implementation of the product admin.
Solution
Breaking changes
none.
Testing
(non-critical issues can go into a list and I can address them in another PR.)