Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues found with new settings pages #238

Closed
7 of 8 tasks
mikemurray opened this issue Mar 5, 2020 · 2 comments · Fixed by #239
Closed
7 of 8 tasks

Issues found with new settings pages #238

mikemurray opened this issue Mar 5, 2020 · 2 comments · Fixed by #239
Assignees
Labels
bug For issues that describe a defect or regression in the released software
Milestone

Comments

@mikemurray
Copy link
Member

mikemurray commented Mar 5, 2020

  • Couldn't save the main shop settings form without adding a shop email. Initially, it didn't seem to give me an error. After entering the email, the forms save consistently. Even if I remove the shop email.

  • Can scroll the layout container. This is hard reproduce, and may just be a general layout issue. Double-check that no other settings subpage or template does overflow scroll other than the ContentViewPrimaryDetailLayout component.
    image

  • Some pages need bottom padding
    image

  • Payment (maybe but it too short to matter)

  • Taxes

  • Shipping

  • System information

  • Address validation

Each card either needs margin-bottom, or you can do this to make it automatic

                <Blocks region="RegionName">
                  {(blocks) =>
                    blocks.map((block, index) => (
                      <Box paddingBottom={2} key={index}>
                        {block}
                      </Box>
                    ))
                  }
                </Blocks>
  • All "save" button should say "save changes" i18nkey "app.saveChanges". Some do, but others don't

  • Consider disabling save buttons if the form isn't dirty. isDirty is available from the useReactoForm hook. disabled={!isDirty || isSubmitting}

  • Cancel button in address dialog should be primary. The secondary blue pops

  • The loading spinners need some height.

  • Sidebar list should highlight the active item

@willopez willopez self-assigned this Mar 5, 2020
@willopez willopez added the bug For issues that describe a defect or regression in the released software label Mar 5, 2020
@willopez willopez added this to the Admin UI milestone Mar 5, 2020
@vandernorth
Copy link

Additionally: I wasn't able to open the email-logs.

@willopez
Copy link
Member

willopez commented Mar 9, 2020

@vandernorth can you provide more details? I see the email logs under the "Email" link

mikemurray added a commit that referenced this issue Mar 13, 2020
…us-ussues

Fix setting views various issues reported in #238
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For issues that describe a defect or regression in the released software
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants