Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reconfigure docker-compose networks #194

Merged
merged 1 commit into from
Jan 31, 2020
Merged

Conversation

aldeed
Copy link
Contributor

@aldeed aldeed commented Jan 30, 2020

There are 5 related PRs that should be tested together:
reactioncommerce/example-storefront#653
reactioncommerce/reaction-hydra#46
#194
reactioncommerce/reaction-identity#23
reactioncommerce/reaction#6068

All of these ensure that docker-compose defines exactly one external network named reaction.localhost and update all services and ENV to use that one. This is being done to cut down on confusion caused by having various arbitrary networks. This affects only local development using docker-compose.

The only downside we're aware of is that project authors need to be more careful about giving Reaction services unique names (e.g., can't call them all web).

One upside in addition to being generally less confusing is that the primary internal hostname for the API is now just api.reaction.localhost rather than the more confusing api.api.reaction.localhost.

Testing

  1. Switch to the PR branches of all 5 projects linked above.
  2. Copy .env.example to .env in each project, completely replacing .env.
  3. Stop all Docker containers.
  4. docker system prune
  5. Delete the docker-compose.override.yml file from each of the project directories. It doesn't technically matter whether you leave the override in place, but everything will start faster if you don't.
  6. In the platform directory, make start.
  7. Once all services are running, check all service logs for errors, and do some basic smoke tests such as logging in to both admin and storefront.

Copy link
Member

@manueldelreal manueldelreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@aldeed aldeed merged commit 61e0162 into trunk Jan 31, 2020
@aldeed aldeed deleted the chore-dc-network-rename branch January 31, 2020 20:52
This was referenced Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants