chore: reconfigure docker-compose networks #194
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 5 related PRs that should be tested together:
reactioncommerce/example-storefront#653
reactioncommerce/reaction-hydra#46
#194
reactioncommerce/reaction-identity#23
reactioncommerce/reaction#6068
All of these ensure that docker-compose defines exactly one external network named
reaction.localhost
and update all services and ENV to use that one. This is being done to cut down on confusion caused by having various arbitrary networks. This affects only local development using docker-compose.The only downside we're aware of is that project authors need to be more careful about giving Reaction services unique names (e.g., can't call them all
web
).One upside in addition to being generally less confusing is that the primary internal hostname for the API is now just
api.reaction.localhost
rather than the more confusingapi.api.reaction.localhost
.Testing
.env.example
to.env
in each project, completely replacing.env
.docker system prune
docker-compose.override.yml
file from each of the project directories. It doesn't technically matter whether you leave the override in place, but everything will start faster if you don't.make start
.