Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add layout for primary/detail view #233

Merged
merged 54 commits into from
Mar 3, 2020

Conversation

mikemurray
Copy link
Member

@mikemurray mikemurray commented Feb 29, 2020

Resolves #223
Impact: major
Type: feature

Issue

A new layout component is needed to satisfy UI requirements for a secondary sidebar with a detail view.

Solution

  • Create the Primary/Detail component
  • Use new layout on Navigation dashboard
  • Add helper hooks
  • Refactor Dashboard
  • Refactor route registration

Screenshots

Mobile with the "more" button

image

Opened menu

image

Breaking changes

Non-breaking name changes when registering operator routes:

  • Old => New
  • layoutComponent => LayoutComponent
  • mainComponent => MainComponent
  • isNavigationLink: true => group: "navigation"
  • isSetting: true => group: "settings"

Warnings will be logged when using the old properties. They'll automatically be transformed into their new values to retain compatibility.

Testing

  1. Run through the app and ensure the views load and look like they should with their layouts.
  2. Pay specific attention to the navigation dashboard
  3. Resize the nav dashboard add to see the "More" button appears
  4. Click to open the menu

Keep in mind the nav editor drag-n-drop doesn't work in the Chrome mobile simulation. Any layout issues not related to the implementation of the Primary/Detail layout can go into another PR.

Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
@mikemurray mikemurray changed the title [WIP] Add layout for primary/detail view Add layout for primary/detail view Mar 3, 2020
@mikemurray mikemurray requested a review from willopez March 3, 2020 03:20
@mikemurray mikemurray marked this pull request as ready for review March 3, 2020 03:20
Copy link
Member

@willopez willopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@willopez willopez merged commit cbe7132 into trunk Mar 3, 2020
@willopez willopez deleted the feat-223-mikemurray-primary-detail-view branch March 3, 2020 18:27
@kieckhafer kieckhafer mentioned this pull request Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Primary/Detail layout view
2 participants