Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Product media fixes #247

Merged
merged 8 commits into from
Apr 1, 2020
Merged

Product media fixes #247

merged 8 commits into from
Apr 1, 2020

Conversation

willopez
Copy link
Member

@willopez willopez commented Mar 27, 2020 •
edited
Loading

Resolves #236
Impact: minor
Type: bugfix

Issue

There are several issues with the product medial gallery, more details provided in #236

Solution

Part of the solution is to refetch product data after images are added to a product.

Breaking changes

None

Testing

  1. Upload multiple media items for a product
  2. Verify all media is uploaded and displayed correctly
  3. Remove media items from a product
  4. Verify media items are correctly removed and UI updates correctly
  5. Set new priorities on various media items
  6. Verify new media item priorities are set correctly

@willopez
fix: add missing media field to product query
cd59918 
Signed-off-by: Will Lopez <[email protected]>
@willopez
fix: refetch product media after media is added to products
27e8e28 
Signed-off-by: Will Lopez <[email protected]>
@willopez
refactor: add better polling of uploaded product media
bbdb8c4 
Signed-off-by: Will Lopez <[email protected]>
@willopez
refactor: improve removing product media flow
b87d165 
Signed-off-by: Will Lopez <[email protected]>
@willopez
refactor: add product refetch function to all product media uploaders
7298066 
Signed-off-by: Will Lopez <[email protected]>
@willopez
refactor: correctly set priority on media items
d1199e2 
Signed-off-by: Will Lopez <[email protected]>
@willopez
refactor: when deleting a media item, return an optimistic response
8f9bd55 
Signed-off-by: Will Lopez <[email protected]>
@willopez willopez marked this pull request as ready for review March 31, 2020 22:36
@willopez willopez requested a review from mikemurray April 1, 2020 20:02
mikemurray
mikemurray approved these changes Apr 1, 2020
View reviewed changes
Copy link
Member

@mikemurray mikemurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mikemurray mikemurray merged commit a52ebe9 into trunk Apr 1, 2020
@mikemurray mikemurray deleted the willopez-fix-product-media branch April 1, 2020 21:42
@kieckhafer kieckhafer mentioned this pull request Apr 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janus-reith janus-reith janus-reith left review comments

@mikemurray mikemurray mikemurray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Revisit product media gallery editor
3 participants
@willopez @mikemurray @janus-reith