Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: de-meteorize discount codes view #255

Merged
merged 9 commits into from
Apr 16, 2020

Conversation

willopez
Copy link
Member

@willopez willopez commented Apr 8, 2020

Resolves #229
Impact: minor
Type: refactor

NOTE: Test with this API plugin PR: reactioncommerce/api-plugin-discounts-codes#2

To test with a local plugin(not yet published to NPM):

  1. create a new plugins folder adjacent to the reaction folder and clone the plugin to test into it.

  2. Remove the plugin from the package.json in Reaction, in this case the plugin-discount-codes

  3. In Reaction docker-compose.dev.yaml add the following line under the volumes section:

      - ../plugins/plugin-discount-codes:/usr/local/src/app/node_modules/@reactioncommerce/plugin-discount-codes
  1. Stop and start the Reaction API

Issue

The discounts view still depends on Meteor

Solution

Remove all Meteor dependencies

Breaking changes

None

Testing

  1. Add/Update/Delete a discount code
  2. Filter discount codes by entering a search keyword
  3. Verify above functionality works correctly

@willopez willopez changed the title refactor: start to de-meteorize discount codes view refactor: de-meteorize discount codes view Apr 10, 2020
@willopez willopez marked this pull request as ready for review April 15, 2020 00:08
Copy link
Member

@mikemurray mikemurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a missing translation for the warning:
image

And the delete button in the modal should be left-aligned:

image

Signed-off-by: Will Lopez <[email protected]>
Copy link
Member

@mikemurray mikemurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mikemurray mikemurray merged commit 7e6cdd5 into trunk Apr 16, 2020
@mikemurray mikemurray deleted the de-meteorized-discount-codes-view branch April 16, 2020 20:21
@kieckhafer kieckhafer mentioned this pull request May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor discount codes to use the GraphQL API
2 participants