Fix navigation tree not showing up

[loan-laux]

Signed-off-by: Loan Laux [email protected]

Resolves #256
Impact: critical
Type: bugfix

Issue

The Navigation page wasn't working because of the navigation tree not showing up.

Solution

Update react-dnd and react-dnd-html5-backend to 9.5.1, and move DndProvider up the component tree (at <App /> level) to avoid conflict with react-router.

Breaking changes

None.

Testing

1. Visit the Navigation page.
2. See the navigation tree.
3. Try moving stuff around. It should work.

[loan-laux]

I've noticed that there's no way to edit a newly added component item before clicking the Save button. Was that the case before or is this a regression?

[loan-laux]

@willopez I can't assign a reviewer here for some reason... Since you were planning on fixing this, do you want to do a code review?

[willopez]

Thanks for this @loan-laux! I'll review it, and I believe that was the case and this PR does not cause a regression. I'll verify when reviewing.

[mikemurray]

I agree with @willopez, I don’t think your changes caused a regression.

[mikemurray]

👍 Look good.

Had to run tests locally since they didn't run on CI. This was fixed on CircleCI and they should run on future pull-requests from forked repos.

[willopez]

LGTM

[loan-laux]

Thanks @willopez @mikemurray. Can we get a release for that? There's also a bunch of other things that are on trunk but not on beta.6, so it would make sense to release a beta.7 IMO.

[willopez]

@loan-laux You are welcomed and thank you for you contribution. We'll get a new beta out soon.