Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead code #317

Merged
merged 27 commits into from
Sep 3, 2020
Merged

Conversation

loan-laux
Copy link
Contributor

@loan-laux loan-laux commented Aug 28, 2020

Impact: major
Type: performance|refactor|chore

Issue

There's a lot of dead code, mainly comprised of unused components, HOCs and pages.

I know that reaction-admin will soon be phased out, but to me it looks like we're still a couple of months away from this happening. I could be wrong, but still, to me it seems that such a clean-up would be welcome to the people and companies who are using reaction-admin on a daily basis.

Solution

This PR removes all of the dead code I could find. Some may have slipped through the cracks, but I believe this will already be a very welcome clean-up.

My methodology with this PR can be described in a single GIF:

Flamethrower

Hence, there's a possibility I could have removed some things that weren't supposed to be removed. I've taken all the precautionary measures I could (test all features, do global searches for usage, etc), but you never know. Testing all kinds of obscure, hidden and forgotten features would be very much appreciated to make sure everything works as it should.

Breaking changes

Not sure but it doesn't appear so. Would appreciate feedback.

Testing

  1. Test every page and every feature. Sorry for not being very specific here but I don't know what else to write.

Signed-off-by: Loan Laux <[email protected]>
@loan-laux loan-laux marked this pull request as ready for review August 31, 2020 07:51
Signed-off-by: Loan Laux <[email protected]>
@loan-laux
Copy link
Contributor Author

@willopez @chrispotter I can't request reviews from you guys, but feel free to assign yourselves and look through the changes when you get a chance.

@willopez willopez self-requested a review September 1, 2020 16:25
@loan-laux
Copy link
Contributor Author

Thanks for the feedback @balibebas. Is it hanging on connection attempts to the DB? Or to the GQL API? Haven't seen that happen on my end, but it's a major issue indeed if it's caused by these changes.

@ghost
Copy link

ghost commented Sep 3, 2020

Thanks for the feedback @balibebas. Is it hanging on connection attempts to the DB? Or to the GQL API? Haven't seen that happen on my end, but it's a major issue indeed if it's caused by these changes.

You're too quick. Right after I wrote that I tried with beta 9 and see it's unrelated to this branch. :D Will let you know when I get it up and running if I can before moving on.

@ghost
Copy link

ghost commented Sep 3, 2020

Tested by building an image as I wasn't able to get the dev link working for this repo. Imported a fresh MongoDB and performed DB migrations. Then registered a user and tested the following:

  • Updating store information (email, name)
  • Adding a test products
  • Adding discounts
  • Adding tags and tag image
  • Updating site navigation
  • Inviting a store owner
  • Creating a new invitee group
  • Inviting user to new group
  • Enabling a payment method
  • Creating a fulfillment method
  • Enabling a custom API plugin
  • Updating shop localization
  • Adding tax information
  • Creating an order
  • Updating fulfillment group
  • Viewing order changes via storefront
  • Capturing an order payment
  • Adding a tracking number
  • Confirming tracking number updated storefront

Didn't encounter any errors and everything looks at parity with the existing beta.9 (and beta.7 save for Accounts).

Copy link
Member

@willopez willopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this much needed clean up! I tested the app and everything seems ok.

@kieckhafer kieckhafer changed the title Remove dead code [WIP] Remove dead code Sep 3, 2020
@kieckhafer kieckhafer changed the title [WIP] Remove dead code Remove dead code Sep 3, 2020
@willopez willopez merged commit e18f1be into reactioncommerce:trunk Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants