Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: make compareAtPrice optional in form schema #322

Merged
merged 1 commit into from
Oct 5, 2020
Merged

bugfix: make compareAtPrice optional in form schema #322

merged 1 commit into from
Oct 5, 2020

Conversation

CristianCucunuba
Copy link
Contributor

Signed-off-by: cristiancc [email protected]

Resolves #320
Impact: minor
Type: bugfix

Issue

The price can't be add on a variant if compareAtPrice is null

Solution

make the field compareAtPrice optional in the form schema

Breaking changes

none

Testing

  1. Create a variant and set the price without touching or adding any value on the field compare at price
  2. Save changes and refresh the page
  3. See the price of the variant updated

@willopez willopez self-requested a review October 5, 2020 20:12
willopez
willopez approved these changes Oct 5, 2020
View reviewed changes
Copy link
Member

@willopez willopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@willopez willopez merged commit b695ed9 into reactioncommerce:trunk Oct 5, 2020
@CristianCucunuba CristianCucunuba deleted the bugfix-compare-at-price branch October 5, 2020 21:49
@mikemurray mikemurray mentioned this pull request Dec 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willopez willopez willopez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When we create a product variant compareAtPrice is mandatory
2 participants
@CristianCucunuba @willopez