Add shouldShowSidebarLink to registerOperatorRoute #329
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact: minor
Type: feature
Issue
There's currently no clean way for developers to programmatically decide whether to show their
reaction-admin
plugin's link in the sidebar depending on the current shop.Solution
Introduce the
shouldShowSidebarLink
option forregisterOperatorRoute
.shouldShowSidebarLink
takes a function that should expect the current shop as its only argument and should return true if the sidebar link should be shown, or false if it shouldn't.Example usage for a link should only be shown when viewing the primary shop:
Breaking changes
None.
Testing
shouldShowSidebarLink
.