fix: Correct "processing changes" translation name #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Manizuca thank you for the pull request. Can you please sign your commit to comply with our DCO? |
Signed-off-by: Matias Zuniga <[email protected]>
Manizuca
force-pushed
the
fix-saveProcessing
branch
from
71690eb
to
c4cbed3
Compare
|
oops, i forgot to signoff. Updated |
willopez
approved these changes
Nov 9, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact: minor
Type: *bugfix
Issue
While saving changes in some forms, "app.settings.saveProcessing" is visible for some milliseconds.
Solution
Change "app.settings.saveProcessing" to "admin.settings.saveProcessing", the correct name used in https://github.com/reactioncommerce/api-plugin-translations/blob/ef7ce859a1320b3effbd481de9dc51f188282f88/src/i18n/en.json#L57