Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Print invoice" link not working #349

Merged

Conversation

loan-laux
Copy link
Contributor

Resolves #348
Impact: critical
Type: bugfix

Issue

When viewing the details of an order, the "Print invoice" link doesn't work because the link's URL doesn't include the current shop ID prefix.

Solution

Include the current shop ID prefix in the link's URL.

Testing

  1. Open an order's details page.
  2. Click "Print invoice".
  3. Notice that the printable invoice opens fine.
  4. Click "Back" to go back to the order's details page.
  5. Notice that the "Back" button works fine.

@Akarshit Akarshit merged commit 75d5f65 into reactioncommerce:trunk Feb 26, 2021
@Akarshit Akarshit mentioned this pull request Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Print invoice" link isn't working
2 participants