-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Add command to start projects in development mode #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: trojanh <[email protected]>
Signed-off-by: trojanh <[email protected]>
Signed-off-by: trojanh <[email protected]>
Signed-off-by: trojanh <[email protected]>
Signed-off-by: trojanh <[email protected]>
Signed-off-by: trojanh <[email protected]>
There's a lot of bootstrapping required on a new installation before we get to starting the apps. All of that bootstrapping's done in the init-* tasks. This adds `init-dev` and per-project examples that can initialize the whole development platform, or a single project, in dev mode. Signed-off-by: Ticean Bennett <[email protected]>
Signed-off-by: Ticean Bennett <[email protected]>
Signed-off-by: Ticean Bennett <[email protected]>
kieckhafer
approved these changes
Jan 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 was able to start up in dev mode, and unlink and link individual projects. Nice work!
🎉 Thanks @trojanh @focusaurus and @kieckhafer! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #97, #83
Impact: minor
Type: feature
Issue
There was no make command to start projects in development mode.
Solution
This continues the work that @trojanh started in #97. Thanks for the submission @trojanh!
Add
make init-dev
andmake dev-<project-name>
command to start projects in development mode.This makes some additions to create init tasks that will configure project(s) for "development mode", which means that
docker-compose.dev.yml
is symlinked todocker-compose.override.yml
in the project directory. The dev overrides configure the project to build and mount local code into the project. That's usually slower.The README contains workflow suggestions.
I removed the global
dev
target that was originally proposed, but left the per-projectdev-<project>
tasks undocumented in the README. Is stopping enough? The README shows documents stopping (same asdev-<project>
) but the explicit operations make it clear to user what's happening. Happy to document it in the README if we're confident the workflow will work for everyone and not trigger more support cases.Breaking changes
None.
Testing
We had some discussion in #98. I think there was some confusion around the expected workflow. So here are testing instructions for a few cases:
Start Everything in Dev Mode
You probably don't want to do this anymore! It's slow and takes more resources.
git clone [email protected]:reactioncommerce/reaction-development-platform.git
cd reaction-development-platform
make init-dev
Switch a Single Project into Dev Mode
Using instructions from README.
git clone [email protected]:reactioncommerce/reaction-development-platform.git
cd reaction-development-platform
make init
Switch a Single Project into Dev Mode
Using experimental
make dev-<project>
target. It's undocumented in README until we have high confidence that it works well.git clone [email protected]:reactioncommerce/reaction-development-platform.git
cd reaction-development-platform
make init
make dev-<project>
Switch a Single Project into Production Mode
docker-compose.override.yml
file is removed in the respective projects