refactor: add default value to shouldIncludeVariantMedia in GQL

definition Signed-off-by: Will Lopez <[email protected]>
reactioncommerce · Apr 2, 2020 · 8b6eaf6 · 8b6eaf6
1 parent b478c4b
commit 8b6eaf6
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/src/core-services/product/schemas/product.graphql b/src/core-services/product/schemas/product.graphql
@@ -21,7 +21,7 @@ type Product {
   "All media for a product"
   media(
     "Determines whether variant media should be included in the product or not"
-    shouldIncludeVariantMedia: Boolean
+    shouldIncludeVariantMedia: Boolean = true
     ): [ImageInfo]
 
   "The product description to use for page `description` meta element in HTML"
@@ -609,8 +609,6 @@ extend type Query {
     "Shop ID"
     shopId: ID!
 
-    "Should variant media be included in the top level product?"
-    shouldIncludeVariantMedia: Boolean
   ): Product
 
   "Query for a list of Products"

diff --git a/src/core-services/product/utils/getProductMedia.js b/src/core-services/product/utils/getProductMedia.js
@@ -15,7 +15,7 @@ export default async function getProductMedia(product, { shouldIncludeVariantMed
 
   let includeVariantMedia = {};
   if (!shouldIncludeVariantMedia) {
-    includeVariantMedia = { "metadata.variantId": { $eq: null } };
+    includeVariantMedia = { "metadata.variantId": null };
   }
 
   const mediaArray = await Media.find(