Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Marketplace] Rethink implementation of order shipping fulfillment flow #2724

Closed
kieha opened this issue Aug 23, 2017 · 5 comments
Closed

[Marketplace] Rethink implementation of order shipping fulfillment flow #2724

kieha opened this issue Aug 23, 2017 · 5 comments

Comments

@kieha
Copy link
Contributor

kieha commented Aug 23, 2017

Referenced from #2613, there is need to rethink the implementation of the order shipping fulfillment flow to make it more flexible and extensible.

We should also rethink the hard coded zeroth indexes of the billing and shipping arrays in the order object. This should be more flexible to allow for multiple billing and shipping objects that might be there in the marketplace implementation.

@spencern
Copy link
Contributor

Additionally we need to think about the flexibility of how we're progressing and regressing workflow steps.

From a comment I made on #2613

I'm always open to new ways to do things, but it seems like we should have "orders/progressStatus" and "orders/regressStatus" methods instead of one method per status.
We could then have a set of workflows that identifies the next or previous status from the existing status and proceeds. There could be different states for items than for orders, and each should be overridable.
This seems like it would make it easier to extend or replace functionality because if you replace the workflow set, then you replace the way that orders progress.

@kieha kieha self-assigned this Aug 24, 2017
@aaronjudd
Copy link
Contributor

@kieha what's the estimated timeline on this? is it in progress? I consider this to be a (asap) critical issue. Can you please schedule a time to review the approach with @spencern or myself on this before beginning.

@aaronjudd aaronjudd added this to the Marketplace Orders milestone Aug 29, 2017
@kieha
Copy link
Contributor Author

kieha commented Aug 29, 2017

@aaronjudd this is not yet in progress. I'll reach out to you and/or @spencern ASAP before I start on it.

@kieha
Copy link
Contributor Author

kieha commented Aug 30, 2017

A bit more discussion/comments on what should be done here to be found in this PR #2759.

In summary:

  • In addition to rewriting the backend methods, a lot of rewrites need to happen in the front end code as well. I've added comments in the respective files, especially imports/plugins/core/orders/client/containers/orderDashboardContainer.js as to what would need to be done.

@aldeed
Copy link
Contributor

aldeed commented Jul 9, 2019

Done in 2.0.0

@aldeed aldeed closed this as completed Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants