[Marketplace] Set order(s) to a specific status #2613

kieha · 2017-08-01T20:00:49Z

Resolves #2341

This allows users with permission to view and process orders to be able to set/update the status of multiple orders in bulk.

How to test

Have at least 10 (preferably new) orders made in your shop
Visit the orders page on the dashboard
Select one order/many orders (hover over the avatar: it rolls over to a check box)

Testing `Bulk Actions`

On the bar that appears at the top, click on the Bulk Actions button
Select the list items in order of how they appear, and you should see the labels in the Shipping column change according to what you select
Select another order/set of orders and randomly choose any order of list item (e.g. select the Labeled option on a new order). You should see a modal that asks if you're sure you want to skip the shipping flow

Testing `Capture`

On the bar that appears at the top, click on the Capture button
Observe the waiting state on the button, then the modal that shows up on success of the action
Open the sidebar for the item selected, scroll to the Invoice section and observe that the payment has been captured

P.S. The Print Invoice and Pick Sheet step that appears on the list under Bulk Actions is not functional yet in this PR.

* switch to official Loggly lib for Node and write new Bunyan connector for it * update bunyan to 2.0.0 * add REACTION_LOG_FORMAT config option * add extra comments about log formatting options

* added default hover style for languages and currencies class #2444 * added accounts css class to div in mainDropdownContainer #2444 * added hover styles for account class #2444 * added hover style for notification class #2444

2452 fix on UI icon toolbar

Fix on tag menu-sidebar glitch

* add new status for mediaGalleryIndicator * i18n translations for tooltips * status-badge styles for media gallery * update media gallery image new / deleted indicator * style updates * lint fix

# Conflicts: # package.json

* simple fix * fix typo & linting * fix linting issues

* imported LoginFormValidation to forgotContainer * imported LoginFormValidation to passwordOverlayContainer * added setTimeout function to delay rendering * wrap component in translations (#2434) * removed setTimeouts from updatePassword.js * added spinner before mounting the component * replaced setTimeout with life-cycle hook(componentWillRecieveProps) #2422 * imported LoginFormValidation to prevent console error

… added. (#2455) * Update current user's name and profile when address is added * Update user's name when address is updated * Get correct admin user's name from env variables

* Move babelrc into package.json * Updated dependencies * Define missing options variable

spencern · 2017-08-17T16:17:54Z

On a UI/UX note, I think the way that inbox handles the visibility of the checkbox makes a lot of sense.

Before anything has been clicked:

After at least one is selected, we're aware of the users intent (to select at least one order), and in inbox they toggle the images to checkboxes without enforcing the hover to make it easier to select multiple.

@rymorgan curious what you think about this. I think it would make selecting multiple easier and wouldn't be a drag on the UI when not selecting orders.

spencern

It works as is for single shop orders.

There are a number of places where the 0th index is hard-coded. This will not work for marketplace orders.
I'm also concerned that the implementation of the different states of the order fulfillment process are not extensible and will be difficult to swap out or override.

I think we could consider merging and fixing the marketplace issues in another PR, but I think we need to figure out the flexibility and extensibility of the order fulfillment workflow now.

spencern · 2017-08-17T17:21:40Z

imports/plugins/core/orders/client/components/orderBulkActionsBar.js

+            picked: false,
+            packed: false,
+            labeled: false,
+            shipped: false


How does this work if there is a shipping workflow that has additional or fewer steps?

spencern · 2017-08-17T17:24:11Z

imports/plugins/core/orders/client/templates/workflow/shippingTracking.js

@@ -77,7 +77,7 @@ Template.coreOrderShippingTracking.events({
  "click [data-event-action=shipmentPacked]": () => {
    const template = Template.instance();

-    Meteor.call("orders/shipmentPacked", template.order, template.order.shipping[0], true);
+    Meteor.call("orders/shipmentPacked", template.order, template.order.shipping[0]);


We can't assume that there is only one shipment for any given order.

template.order.shipping[0] is too brittle for multiple shipments per order and in a marketplace setting we have to support multiple shipments per order.

In general, hard-coding the 0th index for an array is a code smell, especially as we continue to build multi-shop support

spencern · 2017-08-17T17:27:49Z

imports/plugins/core/orders/client/templates/workflow/shippingTracking.js

@@ -193,6 +193,7 @@ Template.coreOrderShippingTracking.helpers({
    const order = Template.instance().order;
    const shipment = order.shipping[0];

-    return shipment.packed && shipment.tracking;
+    return _.includes(shipment.workflow.workflow, "coreOrderWorkflow/packed") && shipment.tracking ||
+    _.includes(shipment.workflow.workflow, "coreOrderWorkflow/packed");


this feels brittle as well. What if there is a custom workflow that doesn't include coreOrderWorkflow/packed (e.g. uses a different workflow, or pre-packed items, etc.)

spencern · 2017-08-17T17:28:33Z

imports/plugins/core/orders/lib/constants.js

+  packed: "Packed",
+  labeled: "Labeled",
+  shipped: "Shipped",
+  delivered: "Delivered"


How would this be overridden or extended?

spencern · 2017-08-17T17:30:40Z

server/methods/core/cart.js

@@ -671,6 +671,11 @@ Meteor.methods({
    order.shipping[0].items.shipped = false;
    order.shipping[0].items.delivered = false;

+    // begin a new shipping workflow for the order
+    order.shipping[0].workflow = {


We can't assume that this shipment is the only shipment.

spencern · 2017-08-17T17:37:26Z

server/methods/core/cart.js

+    order.shipping[0].workflow = {
+      status: "new",
+      workflow: ["coreOrderWorkflow/notStarted"]
+    };
    order.billing[0].currency.exchangeRate = exchangeRate;


This issue seems like it is older than this particular PR because this code is older, but needs to get solved ASAP.

Can't assume that this is the only payment in this order, or that the 0th payment corresponds with this shipment.

I'll repeat myself a few more times: hardcoded 0th indexes are an indicator that code is not ready for marketplace.

Hard coded indexes, 0th especially, in general are a code smell. It's a sign that that the data structure doesn't fit the application, or that you don't have a better way to identify elements in the array other than just arbitrarily taking the first one.

spencern · 2017-08-17T17:42:22Z

server/methods/core/orders.js

+   * @param {Object} shipment - shipment object
+   * @return {Object} return workflow result
+   */
+  "orders/shipmentPicked": function (order, shipment) {


This feels brittle to me as well.

I'm always open to new ways to do things, but it seems like we should have "orders/progressStatus" and "orders/regressStatus" methods instead of one method per status.

We could then have a set of workflows that identifies the next or previous status from the existing status and proceeds. There could be different states for items than for orders, and each should be overridable.

This seems like it would make it easier to extend or replace functionality because if you replace the workflow set, then you replace the way that orders progress.

spencern · 2017-08-17T17:43:18Z

server/methods/core/orders.js

   * @return {Object} return workflow result
   */
-  "orders/shipmentPacked": function (order, shipment, packed) {
+  "orders/shipmentPacked": function (order, shipment) {


See comments on unifying status progression methods in the shipmentPicked comment.

spencern · 2017-08-17T17:43:24Z

server/methods/core/orders.js

+   * @param {Object} shipment - shipment object
+   * @return {Object} return workflow result
+   */
+  "orders/shipmentLabeled": function (order, shipment) {


See comments on unifying status progression methods in the shipmentPicked comment.

rymorgan · 2017-08-17T17:49:30Z

@spencern Yes, totally agree, once you check one box, all the boxes should appear. That makes sense. Will update the design specs.

kieha · 2017-08-17T19:01:26Z

@spencern I agree that the implementation of most of this (the 0th index hard coding) isn't marketplace ideal, and needs to be refined. I also agree with rethinking the order fulfillment workflow to be more flexible and extensible, and I'll look into it, with a bit of direction.

spencern · 2017-08-17T19:02:43Z

@kieha I don't mind guiding or helping with the direction for any of this, let me know if you would like to pair on it sometime.

spencern · 2017-08-17T21:55:22Z

@kieha - here's a ticket from my days as someone who was building a custom store on Reaction that describes some of these concerns
#1278

rymorgan · 2017-08-18T00:00:30Z

@spencern @kieha I've updated the design to reflect the functionality that once you check on check all the rows show as checks.

https://zpl.io/Nbrejea

…ctioncommerce/reaction into kieha-bulk-order-status-2341

spencern · 2017-08-24T22:59:10Z

Merging, additional work will be performed in #2724

kieckhafer and others added 30 commits June 16, 2017 23:57

more props passed to wrapper

ca8c102

fixes for email table

c3467f5

update Email table to use ReactTable

7ac944f

email table convert to ReactTable

48b0893

Bunyan and Loggly updates (#2425)

dd0a77b

* switch to official Loggly lib for Node and write new Bunyan connector for it * update bunyan to 2.0.0 * add REACTION_LOG_FORMAT config option * add extra comments about log formatting options

refactor default admin user creation (#2453)

b64ee84

update memory usage in CircleCI build (#2462)

72d1ad3

finished implementing design

18778df

Navbar hover issue (#2451)

25e8942

* added default hover style for languages and currencies class #2444 * added accounts css class to div in mainDropdownContainer #2444 * added hover styles for account class #2444 * added hover style for notification class #2444

set css property overflow on horizontal to hidden (#2458)

cea9557

[WIP] 2452 fix on UI icon toolbar (#2460)

1d0fd64

2452 fix on UI icon toolbar

[WIP] 2356 fix on tag menu-sidebar glitch (#2472)

1a6a8f3

Fix on tag menu-sidebar glitch

format price string for invoice details

d3e7da5

update media gallery new / deleted image indicators (#2469)

b59263b

* add new status for mediaGalleryIndicator * i18n translations for tooltips * status-badge styles for media gallery * update media gallery image new / deleted indicator * style updates * lint fix

Merge branch 'development' into ek-newGriddle

2c58cba

# Conflicts: # package.json

Remove random regex checks on names. Fixes #2461 (#2471)

c9a0b28

remove older Blaze based launchdock plugin (#2467)

670ee6b

2459 router range error fix (#2476)

e87ea72

* simple fix * fix typo & linting * fix linting issues

custom pagination component for React-Table

8166dc1

update Avalara to use ReactTable

bcb1fa3

add spacing below tables

ee7d9a7

Merge branch 'development' into ek-newGriddle

e083bb0

Update current user's name on Navbar and profile page when address is…

c27f70e

… added. (#2455) * Update current user's name and profile when address is added * Update user's name when address is updated * Get correct admin user's name from env variables

Merge branch 'development' into ek-newGriddle

698ed21

add invoice actions

0b97a00

Updated dependencies (#2463)

3144dc3

* Move babelrc into package.json * Updated dependencies * Define missing options variable

Merge branch 'development' into ek-newGriddle

b16eb03

remove leftover console.logs

9c07755

lint fixes

df80998

Njeri Kieha added 2 commits August 17, 2017 14:57

Rename variable

dc73ba1

Add back missing 'Processing' translation

487b97f

Njeri Kieha added 2 commits August 17, 2017 19:20

Fix random opening of status bar

79f9034

Use props as passed down from parent container

993ca17

spencern suggested changes Aug 17, 2017

View reviewed changes

Merge branch 'marketplace' into kieha-bulk-order-status-2341

e4ce99d

Njeri Kieha added 8 commits August 18, 2017 15:59

Merge branch 'marketplace' into kieha-bulk-order-status-2341

09917fe

Turn all avatars to checkboxes on order select

ea2131b

Add printing step to flow list

ec80a2d

Merge branch 'kieha-bulk-order-status-2341' of https://github.com/rea…

6dc056f

…ctioncommerce/reaction into kieha-bulk-order-status-2341

Enable Capture button

2e63b52

Merge branch 'marketplace' into kieha-bulk-order-status-2341

c76d9d3

Set loading state of captore button to false on error

63aa52a

Rename file names

ab35062

kieha mentioned this pull request Aug 23, 2017

[Marketplace] Rethink implementation of order shipping fulfillment flow #2724

Closed

Fix error on payment approving

678321d

spencern approved these changes Aug 24, 2017

View reviewed changes

Fix conflicts with marketplace branch

1748247

spencern merged commit ab498c7 into marketplace Aug 24, 2017

spencern deleted the kieha-bulk-order-status-2341 branch August 24, 2017 22:59

kieha mentioned this pull request Aug 29, 2017

Fix broken marketplace orders dashboard #2759

Merged

impactmass mentioned this pull request Oct 6, 2017

Migration updates to fix Localization, uol, and paymentMethod errors on 1.0 > 1.5 #3020

Merged

spencern mentioned this pull request Oct 11, 2017

Release 1.5.0 #3089

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Marketplace] Set order(s) to a specific status #2613

[Marketplace] Set order(s) to a specific status #2613

kieha commented Aug 1, 2017 •

edited

Loading

spencern commented Aug 17, 2017

spencern left a comment

spencern Aug 17, 2017

spencern Aug 17, 2017

spencern Aug 17, 2017

spencern Aug 17, 2017

spencern Aug 17, 2017

spencern Aug 17, 2017

spencern Aug 17, 2017

spencern Aug 17, 2017

spencern Aug 17, 2017

rymorgan commented Aug 17, 2017

kieha commented Aug 17, 2017

spencern commented Aug 17, 2017

spencern commented Aug 17, 2017 •

edited

Loading

rymorgan commented Aug 18, 2017

spencern commented Aug 24, 2017

[Marketplace] Set order(s) to a specific status #2613

[Marketplace] Set order(s) to a specific status #2613

Conversation

kieha commented Aug 1, 2017 • edited Loading

How to test

Testing Bulk Actions

Testing Capture

spencern commented Aug 17, 2017

spencern left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rymorgan commented Aug 17, 2017

kieha commented Aug 17, 2017

spencern commented Aug 17, 2017

spencern commented Aug 17, 2017 • edited Loading

rymorgan commented Aug 18, 2017

spencern commented Aug 24, 2017

kieha commented Aug 1, 2017 •

edited

Loading

Testing `Bulk Actions`

Testing `Capture`

spencern commented Aug 17, 2017 •

edited

Loading