Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ReactionCore.registerPackage schema #314

Closed
aaronjudd opened this issue Feb 9, 2015 · 0 comments
Closed

Refactor ReactionCore.registerPackage schema #314

aaronjudd opened this issue Feb 9, 2015 · 0 comments
Assignees

Comments

@aaronjudd
Copy link
Contributor

Refactor the ReactionCore.registerPackage package schema to be more structured.
Only registry is to be published to general client, while others (settings,permissions) would be published when admin.

ReactionCore.registerPackage
  name: 'reaction-paypal' # usually same as meteor package
  autoEnable: false # auto-enable in dashboard
  settings: # private package settings config (blackbox)
    mode: false
    client_id: ''
    client_secret: ''
  registry: [
    # all options except route and template
    # are used to describe the
    # dashboard 'app card'.
    {
      provides: 'dashboard'
      label: 'PayPal'
      description: 'Accept PayPal payments'
      icon: 'fa fa-paypal'
      priority: '2'
      group: 'paypal'
    }
    # configures settings link for app card
    # use 'group' to link to dashboard card
    {
      route: 'paypal'
      provides: 'settings'
      group: 'paypal'
    }
    # configures template for checkout
    # paymentMethod dynamic template
    {
      template: 'paypalPaymentForm'
      provides: 'paymentMethod'
    }
  ]
  # array of permission objects
  permissions: [
    {
      label: 'Pay Pal'
      permission: 'dashboard/payments'
      group: 'Shop Settings'
    }
  ]

I'd like to attempt to resolve #53, #308, #178, #136, #245 as well in this refactor.

@aaronjudd aaronjudd added this to the Core Architecture milestone Feb 9, 2015
@aaronjudd aaronjudd added ready and removed ready labels Feb 9, 2015
@aaronjudd aaronjudd self-assigned this Feb 11, 2015
aaronjudd added a commit to taylorsmithgg/reaction-auth-net that referenced this issue Feb 14, 2015
aaronjudd added a commit that referenced this issue Dec 3, 2015
Changes that refactor the `ReactionCore.registerPackage`
implementation to a more flexible, and structured template
registry. `ReactionCore.registerPackage` moves to server.
package.registry is published to client.

These are not backwards compatible changes.

Updated documentation at docs/packages.md

Initial commit for issue #314

Strategic updates for Issue #273
Strategic updates for Issue #306
Strategic updates for Issue #305
Strategic updates for Issue #246
Strategic updates for Issue #183
Strategic updates for Issue #155
Strategic updates for Issue #16
Strategic updates for Issue #148

Resolves #53
Resolves #308
Resolves #178

*Remaining tasks*

solve undefined error
convert the rest of the payment packages
context sensitive widgets (context?)
update with detailed docs
(document all the existing "provides")
aaronjudd added a commit that referenced this issue Dec 3, 2015
##package-registry-refactor
Changes that refactor the `ReactionCore.registerPackage`
implementation to a more flexible, and structured template
registry. `ReactionCore.registerPackage` moves to server.
package.registry is published to client.

cycle = Core, Stable, Testing (todo: => correlates package semver)
container = combine multiple registry entries

These are not backwards compatible changes.

Updated documentation at docs/packages.md

Initial commit for issue #314

Strategic updates for Issue #273
Strategic updates for Issue #306
Strategic updates for Issue #305
Strategic updates for Issue #246
Strategic updates for Issue #183
Strategic updates for Issue #155
Strategic updates for Issue #16
Strategic updates for Issue #148
Strategic updates for Issue #146

Resolves #53
Resolves #308
Resolves #178
aaronjudd added a commit that referenced this issue Dec 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant