Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variant option field spacing is off #32

Closed
bstocks opened this issue Apr 13, 2014 · 2 comments
Closed

Variant option field spacing is off #32

bstocks opened this issue Apr 13, 2014 · 2 comments

Comments

@bstocks
Copy link
Contributor

bstocks commented Apr 13, 2014

Fields are not vertically centered within the container.

example product1
@aaronjudd
Copy link
Contributor

Fields should probably also use the full row width. Trash can should be fa-circle-o as well, since we've starting using that everywhere else (to be consistent)

@aaronjudd
Copy link
Contributor

Resolved in https://github.com/ongoworks/reaction-core/commit/9154e0c2750f5380c42f7ddefa18791dd06b4492

cmbirk pushed a commit to cmbirk/reaction that referenced this issue Aug 18, 2019
@spencern
Merge pull request reactioncommerce#32 from sportsdirect/upstream-fix…
9012a05 
…-inventory

Upstream fix inventory
@snyk-bot snyk-bot mentioned this issue Aug 14, 2020
Open
@snyk-bot snyk-bot mentioned this issue Sep 29, 2021
Merged
This was referenced Mar 2, 2022
Closed
Closed
This was referenced Jul 20, 2022
Open
Open
brent-hoover pushed a commit that referenced this issue Sep 20, 2022
@Akarshit
Merge pull request #32 from reactioncommerce/dependabot/npm_and_yarn/…
0b88b59 
…ws-7.4.6

chore(deps): Bump ws from 7.2.3 to 7.4.6
brent-hoover pushed a commit that referenced this issue Sep 20, 2022
@Akarshit
Merge pull request #32 from reactioncommerce/dependabot/npm_and_yarn/…
5334382 
…trim-newlines-3.0.1

chore(deps): bump trim-newlines from 3.0.0 to 3.0.1
brent-hoover pushed a commit that referenced this issue Sep 20, 2022
@Akarshit
Merge pull request #32 from reactioncommerce/dependabot/npm_and_yarn/…
3728179 
…browserslist-4.16.7

chore(deps): bump browserslist from 4.12.0 to 4.16.7
brent-hoover pushed a commit that referenced this issue Sep 20, 2022
@delagroove
Merge pull request #32 from reactioncommerce/snyk-upgrade-deac65b32c8…
1822b73 
…49a0c61d2262afe8e1af2

[Snyk] Upgrade @reactioncommerce/api-utils from 1.16.5 to 1.16.7
brent-hoover pushed a commit that referenced this issue Sep 20, 2022
@delagroove
Merge pull request #32 from reactioncommerce/akarshit-chore-integrati…
88c9e71 
…on-test

chore: add integration tests
brent-hoover pushed a commit that referenced this issue Sep 20, 2022
@delagroove
Merge pull request #32 from reactioncommerce/akarshit-chore-integrati…
124afc3 
…on-test

chore: add integration tests
brent-hoover pushed a commit that referenced this issue Sep 20, 2022
@delagroove
Merge pull request #32 from reactioncommerce/dependabot/npm_and_yarn/…
62de5fc 
…tmpl-1.0.5

chore(deps): Bump tmpl from 1.0.4 to 1.0.5
brent-hoover pushed a commit that referenced this issue Sep 20, 2022
@delagroove
Merge pull request #32 from reactioncommerce/dependabot/npm_and_yarn/…
d6b02d0 
…semver-regex-3.1.3

chore(deps): Bump semver-regex from 3.1.2 to 3.1.3
brent-hoover pushed a commit that referenced this issue Sep 20, 2022
@delagroove
Merge pull request #32 from reactioncommerce/snyk-upgrade-eb1b8f9293b…
a513724 
…c5711c084e3e34cd6ece8

[Snyk] Upgrade @reactioncommerce/logger from 1.1.3 to 1.1.4
brent-hoover pushed a commit that referenced this issue Sep 20, 2022
@MohanNarayana
Merge pull request #32 from reactioncommerce/fix-mohan-16-extend-cont…
9ed7b7f 
…ext-schema

chore: add transformAndValidateCart tests
brent-hoover added a commit that referenced this issue Sep 20, 2022
@brent-hoover
Merge pull request #32 from reactioncommerce/akarshit-chore-integrati…
24d1b4e 
…on-test

chore: add integration tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aaronjudd @bstocks