Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make coffeescript syntax for @userId more consistent in publications #395

Closed
3 tasks done
queso opened this issue Jul 1, 2015 · 0 comments
Closed
3 tasks done

Make coffeescript syntax for @userId more consistent in publications #395

queso opened this issue Jul 1, 2015 · 0 comments
Assignees
@queso

Comments

@queso
Copy link
Contributor

queso commented Jul 1, 2015

@queso queso self-assigned this Jul 1, 2015
jshimko pushed a commit that referenced this issue Dec 3, 2015
@queso
Make publications more consistent. Fixes #395.
7aff36b
aaronjudd pushed a commit that referenced this issue Dec 3, 2015
Merge pull request #144 from reactioncommerce/consistency
bf8136e 
Make publications more consistent. Fixes #395.
jshimko pushed a commit that referenced this issue Dec 3, 2015
@spencern
Much better solution to inventory variant inventory quantity problem - …
c532991 
…#343. Adds tests, and fixes issue where parent/grandparent quantities were not adding up properly. (11 Squashed)

Squashed commits:
[272ddf1] Make publications more consistent. Fixes #395.
[be04b1c] Allow database ids as valid slug for tags.

Bevor this change it was for example not possible to use a product id
as name (slug) for a tag, because the application interpreted the id as
a tag id, instead of a tag name.

A valid use case would be to display a link to a product's related products.
Allowing a product's id as tag name (slug) it is easy to build an URL to related products e.g.
product/tag/<product_id> .

The old behaviour is still in service as a fallback.
[9cf1232] remove testing logging.
[97a4a5f] Update inventory calculator again. Passes all tests against inventory calculation, is less brittle, and faster.
[207c0ad] WIP: Still need some work to update all variants if/when the inventory starts wrong.
[c360ae1] Fix issue where inventory was undefined if variant was new option
[2beb2a0] Compensate for bootstrap's padding when applying .container-fluid class.
[0055b68] Replace brittle inventory update hook with slightly more robust update hook that will update all ancestors in parent chain.
[7f6a91c] Update inventoryVariant tests to test creation of variable quantities of inventoryVariants being added.
[192b7c5] Addl Inline doc for cloneVariant method.
cmbirk pushed a commit to cmbirk/reaction that referenced this issue Aug 18, 2019
@chrisbalchin
Merge pull request reactioncommerce#395 from sportsdirect/brent-daily…
a558ae8 
…-update-jun-26-2019

Daily update jun 26 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@queso queso

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@queso