Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publishing workflow #415

Closed
aaronjudd opened this issue Jul 16, 2015 · 5 comments
Closed

Publishing workflow #415

aaronjudd opened this issue Jul 16, 2015 · 5 comments

Comments

@aaronjudd
Copy link
Contributor

aaronjudd commented Jul 16, 2015

From discussion started on https://github.com/reactioncommerce/reaction-core/pull/146

I've been thinking that it's probably time to consider more complex publishing / workflow rules. I think maybe "isVisible" could be refactored to a more flexible object (and probably preserve isVisible as a method):

Products

    active: "false" || boolean  # replace isVisible for creator
    publish: [ beginDate, endDate] # replaces isVisible for public

When a product is `active`, it's visible / not visible to it's creator.

When a product is published we add a start date, with an *optional *end date.

There could potentially be multiple date ranges (for example, to publish only on specific weekends)

When viewing a grid, we'll add some UI element to toggle the appearance / publication in grids of "active:false" products.

Shops


    workflowRoles:[
        products:
            create: [ {shopId,'createProduct'} ]
            publish: [ {shopId,['admin','owner'] } ]
            view:[ {shopId,'guest'} ]
    ]

Here's some use cases for this publishing structure:

* A user with appropriate permissions  `['admin','owner','createProduct']` can create a product.
* Shop A should be able to give Shop B access to unpublished view
* Shop A (uber shop) could have permission to publish products from Shop B (and perhaps Shop B cannot their own products)
* Shop B can publish products, but only to their shop (i.e.: not Shop A)
* Shop B users can view products from Shop A, but only when shop A allows viewing
* default permissions can be setup like in example definition, as the fallback in case workflowRoles isn't defined.

Possibly we should consider route/tags in publishing permissions as well, for instance, if a certain user has permissions to publish without review in just one category.

* workflowRoles could be specific to Tag

@spencern suggests:

Here's a few more suggestions for product visibility rules and flags
CatalogVisible: true: product is will show up in relevant catalog pages, category searches, etc
CatalogVisible: false: product will only be visible via direct link

I think that just not tagging something could work to exclude it from the catalog, but ideally (in the future perhaps) we will be able to create 'smart' catalogs that organize ever product from a given vendor, within a certain price range, etc. It's in those cases that having an include/exclude flag might be nice.
@aaronjudd
Copy link
Contributor Author

Moving this to the 0.17 release - this is a more detailed discussion on the product publishing workflow that is partially implemented with new PDP updates. when we finish those for 0.17 we should review the items here and close/pluck into new issues as needed. See #415 and #151

@aaronjudd aaronjudd modified the milestones: v0.19.0, v0.17.0 Sep 21, 2016
@aaronjudd aaronjudd removed this from the v0.19.0 milestone Jan 11, 2017
@aaronjudd aaronjudd added this to the Marketplace Catalog milestone Apr 27, 2017
@aaronjudd
Copy link
Contributor Author

Very old discussion of publishing workflows, that should be reviewed and closed as new catalog workflows are defined.

@aaronjudd aaronjudd removed this from the Marketplace Catalog milestone Feb 1, 2018
@brent-hoover
Copy link
Collaborator

Closing to Review roadmap

@aaronjudd
Copy link
Contributor Author

Feature request that requires more definition to meet our current issue guidelines.

@brent-hoover
Copy link
Collaborator

Issue moved to reactioncommerce/reaction-feature-requests #16 via ZenHub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants