Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All non-guest account published to admin user. #4374

Closed
Akarshit opened this issue Jun 27, 2018 · 1 comment · Fixed by #4338
Closed

All non-guest account published to admin user. #4374

Akarshit opened this issue Jun 27, 2018 · 1 comment · Fixed by #4338
Assignees

Comments

@Akarshit
Copy link
Contributor

Issue Description

When a admin logs in, all the non-guest accounts are published to the client. This causes the browser to hang as there could be large number of "customers".

Steps to Reproduce

  1. Run reaction.
  2. Register a account.
  3. Log out
  4. Sign-in as admin.
  5. Check the minimongo database, in which the Accounts collection will have the account of the customer created in step 2.

Possible Solution

From here https://github.com/reactioncommerce/reaction/blame/12cd570f9460766e7adeb7f1625b4a954b8ae87e/server/publications/collections/accounts.js#L25
I see that initially we were not publishing "guest" and "customer", but now we are publishing the "customer" accounts, maybe we can just revert this as we don't show the "customer" accounts to the admin anywhere.

Versions

v 1.13.0

@loanlaux
Copy link

Clients of mine running a Reaction store with 29,000+ users are unable to log in as admin because of this issue. Literally noticed it yesterday, nice timing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants