-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for imports and migrations #467
Comments
There is certainly a need for some good integration points and something we've talked about a fair amount - but haven't yet made any concrete plans. We do have the |
Some things to consider:
A first use case to start on the integrations might be to support simple importing of product catalogs. This however has some dependencies on #150. My idea for a first implementation might consist of:
(something along the lines of import.js) |
This might be a little late, as we've had a few discussions elsewhere, but this is an update to bring this issue up to speed, and I've also thrown in some related points here and links to other pertinent issue so that we can get a cohesive coverage on this. We've discussed replacing some of the current core fixture load with new functionality being developed in the https://github.com/tdecaluwe/reaction-import package. This is inline with ongoing generalized efforts to make reaction core more modular. This is referenced in #451, but has always been a core principal. Some of the current fixture data truly is fixture data, not just sample import data, i.e.: there are not methods to generate the required values in some cases (like currencies,etc) so it might be tough to get a properly configured shop without this sample-data to start with. Factories also aren't generating a full data set, right now the fixtures .json has the most accurate and complete data. Any changes in #508 should remain compatible with the current structure if at all possible, or at least let's make sure that we document the breaking change. Particularly if we're thinking that it will require an update like https://github.com/reactioncommerce/reaction-shipping/pull/4, and possibly a PR to reaction-sample-data. The philosophy I had been following, is that packages should be more independent from each other, or core, and need to be able to load their own fixture data (which is why core, and shipping follow this paradigm). After all, if you don't want to use It also doesn't make any sense to have a sample-data package for each package, so I think this is another argument for packages importing their own fixture loadData. At least for non-core packages, the Allow bringing your own fixture data issue #508 at first glance seems to be the functionality that already was provided with
Simply leaving However, then you'd continue to have the same issue if you wanted to override the data in Image importing would resolve #60, but seems like Consider #317 as well, for some additional thoughts about package acceptance in general. Documentation will need to be updated in fixtures.md Hopefully we can do a thorough update to those docs, particularly with some example import routines. |
About some of the remarks you made:
|
…-update-aug-2-2019 Daily update aug 2 2019
I've recently started working on a reaction integration with a (rather obscure) ERP software used at our company. This means different kinds of entities need to be imported and possibly synced with their counterparts in the ERP database.
However, the basic functionality will be the same when doing SAP, Odoo, Magento or #378 integrations/migrations. Wrapping these in a simple import API might avoid duplicating these functionalities. I'm essentially talking about a set of idempotent operations importing products, variants, prices, stock, invoices, images... I think these should be provided by reaction-core (also it doesn't add client code).
Plugins can be written to talk to different ERP's. Automatic importing could also be provided by a plugin.
Anyway, this issue was in the first place meant as a place to discuss. Thoughts?
The text was updated successfully, but these errors were encountered: