Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move pricing fields and code to a simple-pricing included plugin #4970

Closed
aldeed opened this issue Feb 7, 2019 · 2 comments
Closed

Move pricing fields and code to a simple-pricing included plugin #4970

aldeed opened this issue Feb 7, 2019 · 2 comments

Comments

@aldeed
Copy link
Contributor

aldeed commented Feb 7, 2019

Background

There are newer and better pricing models in development, but existing pricing code is currently spread across several core plugins. If a custom pricing plugin is added, it will have data alongside the current pricing fields, which would not be used. This would be confusing.

Work

Move all code and schemas related to product and catalog pricing into an included plugin, which should be removable. The goal is to be able to remove it and swap in a different custom pricing plugin, with everything still working.
@nnnnat nnnnat self-assigned this Feb 27, 2019
@nnnnat nnnnat added this to the 🏔 Torreys milestone Feb 27, 2019
@nnnnat nnnnat mentioned this issue Feb 28, 2019
Merged
@aldeed
Copy link
Contributor Author

aldeed commented Mar 31, 2019

This is mostly done by #5014, but we should do an audit to be sure everything is moved to the plugin. I think we skipped a few things due to time constraints.

@aldeed aldeed mentioned this issue Apr 23, 2019
Merged
@aldeed aldeed assigned aldeed and unassigned nnnnat Apr 23, 2019
@aldeed aldeed removed their assignment Dec 16, 2019
@aldeed aldeed removed this from the 🏔 Torreys milestone Dec 16, 2019
@aldeed
Copy link
Contributor Author

aldeed commented Jan 29, 2020

Did some searching and tested out removing simple-pricing plugin in 3.0 branch. Seems like this is done.

@aldeed aldeed closed this as completed Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nnnnat @aldeed