-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: simple-pricing plugin #5014
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Combine the main .env.example file with any .env.example files from custom plugins during setup - ignore blank lines - also format with shfmt - also fix one shellcheck lint error Signed-off-by: Peter Lyons <[email protected]> Signed-off-by: Nat Hamilton <[email protected]>
feat: Use .env.example files from custom plugins Signed-off-by: Nat Hamilton <[email protected]>
…ng queries. Signed-off-by: Nat Hamilton <[email protected]>
nnnnat
force-pushed
the
refactor-4970-nnnnat-simple-pricing
branch
from
February 28, 2019 16:10
960a61e
to
157503e
Compare
Signed-off-by: Nat Hamilton <[email protected]> Signed-off-by: Nat Hamilton <[email protected]> Signed-off-by: Nat Hamilton <[email protected]>
…icing data. Signed-off-by: Nat Hamilton <[email protected]> Signed-off-by: Nat Hamilton <[email protected]> Signed-off-by: Nat Hamilton <[email protected]>
nnnnat
force-pushed
the
refactor-4970-nnnnat-simple-pricing
branch
2 times, most recently
from
February 28, 2019 16:14
eea2468
to
dabb0db
Compare
Signed-off-by: Nat Hamilton <[email protected]> Signed-off-by: Nat Hamilton <[email protected]> Signed-off-by: Nat Hamilton <[email protected]>
nnnnat
force-pushed
the
refactor-4970-nnnnat-simple-pricing
branch
2 times, most recently
from
February 28, 2019 16:35
cca671b
to
5db034a
Compare
nnnnat
changed the title
feat: created simple-pricing plugin, created a few cart related prici…
feat: simple-pricing plugin
Feb 28, 2019
Signed-off-by: Eric Dobbertin <[email protected]>
Signed-off-by: Eric Dobbertin <[email protected]>
Signed-off-by: Eric Dobbertin <[email protected]>
aldeed
approved these changes
Mar 1, 2019
Signed-off-by: Eric Dobbertin <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4970
Impact: minor
Type: feature|refactor
Issue
Pricing data falls under it's own domain within the Reaction Commerce system, however it currently needs to be intertwined and available from other system domains (i.e., Catalog, Cart, Checkout, Orders).
Solution
To give us more flexibility in pricing data management we've begun to move pricing get/set functions into this
simple-pricing
plugin and calling these functions from thecontext.queries
object from within their respective functions. Now we can fully replace the pricing management system without modification to core by creating a custom plugin that replaces thesimple-pricing
queries.Testing
While this acceptance test is testing multiple things it can be done in one pass.
Adding Cart Items
Price Change
5. From the RC admin select one of the products you've added to your cart in the Storefront.
6. From the products edit screen select the option, change the price then publish the product changes to the catalog.
7. From the Storefront click the cart icon to go to the cart page.
8. From here you should see you're cart item's price has been updated to the new price.
Checkout
9. Now click "checkout" and follow finishes the checkout flow.
10. You should see the correct prices for each item in the checkout review.
11. Place the order, the order should be accepted and you'll be met with the completed order view displaying the products with the prices paid.