Add currency symbol for displayPrice product property

[willopez]

Prerequisites

• Are you running the latest version?
• Are you able to consistently reproduce the issue?
• Did you search the issue queue for existing issue? Search issues

Issue Description

The pricing prop in products/variants has a property displayPrice that is missing the currency symbol.

Possible Solution

Add current shop's settings to app context, which would include the shop's currency. With currency information available in the app context, it would be trivial to add the currency symbol the displayProp

[aldeed]

@willopez There is no such thing as a "current" shop. Shop always needs to be looked up based on the data in question. So for product pricing it would be something like.

import getCurrencyDefinitionByCode from "@reactioncommerce/api-utils/getCurrencyDefinitionByCode.js";

const shop = await Shops.findOne({ _id: productOrVariant.shopId }, { projection: { currency: 1 } });
const currencyDefinition = getCurrencyDefinitionByCode(shop.currency);
const displayPrice = getDisplayPrice(minPrice, maxPrice, currencyDefinition);

[mikemurray]

Getting the currency was added in this PR: #6159 but, I think it could be improved further by, either...

• checking if displayPrice was requested then calculating it, only if it was
• or, maybe by adding / update a separate resolver for display price to query when needed

[aldeed]

Agree. What I would really prefer is to store all of the pricing data, including displayPrice, in the database whenever the price is changed. Then nothing needs to be transformed at read time. But this would require a large initial migration plus a way to schedule a migration whenever someone changes the shop currency.