fix: adds new pricing field to product variants in order to correctly display prices #6159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
display prices. Signed-off-by: Will Lopez <[email protected]>
mikemurray
requested changes
Mar 25, 2020
src/plugins/simple-pricing/xforms/xformProductVariantPricing.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Will Lopez <[email protected]>
…actioncommerce/reaction into refactor-use-consistent-pricing-field
mikemurray
previously requested changes
Mar 26, 2020
There was a problem hiding this comment.
I'm seeing an issue where the data in the database is saved incorrectly for Variants with Options. The price min and max are being saved as objects instead of as floats. I'm also seeing incorrect values for the price ranges for the Product, and top-level Variant, likely due to this bug. Something may be wrong with the updateVariantPrices mutation or app events thereafter.
src/plugins/simple-pricing/xforms/xformProductVariantPricing.js
Outdated
Show resolved
Hide resolved
src/plugins/simple-pricing/xforms/xformProductVariantPricing.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Will Lopez <[email protected]>
willopez
dismissed
mikemurray’s stale review
creating new issue for remaining changes.
|
Currency symbol issue: #6162 |
Signed-off-by: Will Lopez <[email protected]>
3 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6152
Impact: minor
Type: bugfix
NOTE test with PR: reactioncommerce/reaction-admin#246
Issue
Description of the issue this PR is solving, why it's happening, and how to reproduce it. This may differ from the original ticket as you now have more information at your disposal.
Solution
The
pricefield on variants was not flexible enough to accommodate a variant having options with their own prices. A new fieldpricinghas been added to theProductandProductVarianttypes. This new field has a transformer that determines the correct value to return depending on whether a variant is a parent variant or not.Breaking changes
None.
NOTE The field
pricehas been deprecated in favor ofpricingboth on products and variants.Testing