Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create shipping admin interface #73

Closed
saralouhicks opened this issue May 27, 2014 · 18 comments
Closed

Create shipping admin interface #73

saralouhicks opened this issue May 27, 2014 · 18 comments
Assignees

Comments

@saralouhicks
Copy link
Member

Create a way for shop owners to manage their shipping settings and rules.

Once created, we need to update the shipping.md guide.

@aaronjudd aaronjudd added this to the v0.2.3 milestone Nov 7, 2014
@bstocks
Copy link
Contributor

bstocks commented Dec 8, 2014

Relates to #100

Are there shop-level shipping settings that need their own interface, or can all shipping settings be managed within each individual carrier's app in the dashboard?

@aaronjudd
Copy link
Contributor

There will be a shop level admin, that each carrier package can add to the same interface.

@bstocks
Copy link
Contributor

bstocks commented Dec 8, 2014

Ok, so then you would add a carrier from the app gallery, adjust carrier-specific settings (like credentials) on the app, but then adjust actual shipping rates, etc from a single shop level admin screen?

@aaronjudd
Copy link
Contributor

yes, that's how I see it.

@aldeed
Copy link
Contributor

aldeed commented Dec 10, 2014

@aaronjudd, is this why I'm seeing "Heads up! No shipping methods enabled." in the v0.2.2 branch? Should I be using the other v0.2.2 branch? How do I enable a shipping method?

@aaronjudd
Copy link
Contributor

I was wondering where that went! Let me fix in my branch, it's a small change

@aaronjudd
Copy link
Contributor

Actually if you can just use the shipping html from v.02.1 https://github.com/reactioncommerce/reaction-core/blob/master/client/templates/cart/checkout/shipping/shipping.html it should be ok.

@aldeed
Copy link
Contributor

aldeed commented Dec 10, 2014

I was just trying that, but I'm getting errors

@aaronjudd
Copy link
Contributor

ok, let me take a closer look

@aldeed
Copy link
Contributor

aldeed commented Dec 10, 2014

Although, it seems like it might be working despite the errors. There's an error, and then after a few seconds, the shipping options appear.

@aaronjudd
Copy link
Contributor

ok, then more of a timing issue - the rates are returning from a method, and then updating the cart, so that's the delay.

@aaronjudd aaronjudd modified the milestones: Shipping Workflow, v0.2.4 Jan 19, 2015
@aaronjudd aaronjudd self-assigned this Jan 19, 2015
@aaronjudd
Copy link
Contributor

Remaining on this issue:

@bstocks
Copy link
Contributor

bstocks commented Jan 20, 2015

Minor item:

It looks like the confirmation page (reaction-core/client/templates/cart/checkout/completed/completed.html) is looking for the shipment method label at shipping.shipmentMethod.label in the Orders collection, but the label actually lives in shipping.shipmentMethod.method.label.

@bstocks
Copy link
Contributor

bstocks commented Jan 20, 2015

Also, there is an error (included below) that gets thrown in the very last step of the cart flow right before confirmation. It doesn't seem to effect the order getting created correctly or really cause any problems at all. Seems like it might just be a timing issue between the cart getting destroyed but the coreCheckoutShipping template helper still looking for it.

Exception in template helper: TypeError: Cannot read property 'shipping' of undefined
    at Object.Template.coreCheckoutShipping.helpers.isSelected (http://localhost:3000/packages/reactioncommerce_core.js?72f54734cfbffbcbe37339dc6d21cc908c50421d:31843:61)
    at http://localhost:3000/packages/blaze.js?efa68f65e67544b5a05509804bf97e2c91ce75eb:2727:16
    at http://localhost:3000/packages/blaze.js?efa68f65e67544b5a05509804bf97e2c91ce75eb:1606:16
    at Spacebars.call (http://localhost:3000/packages/spacebars.js?3c496d2950151d744a8574297b46d2763a123bdf:169:18)
    at Spacebars.mustacheImpl (http://localhost:3000/packages/spacebars.js?3c496d2950151d744a8574297b46d2763a123bdf:106:25)
    at Object.Spacebars.mustache (http://localhost:3000/packages/spacebars.js?3c496d2950151d744a8574297b46d2763a123bdf:110:39)
    at HTML.LI.class (http://localhost:3000/packages/reactioncommerce_reaction-shipping.js?1d3f5d149db083dcb39e8c7f85f21fac33e145f7:919:50)
    at Object.Blaze._withCurrentView (http://localhost:3000/packages/blaze.js?efa68f65e67544b5a05509804bf97e2c91ce75eb:2043:12)
    at Blaze._HTMLJSExpander.def.visitAttribute (http://localhost:3000/packages/blaze.js?efa68f65e67544b5a05509804bf97e2c91ce75eb:1971:21)
    at HTML.TransformingVisitor.def.visitAttributes (http://localhost:3000/packages/htmljs.js?567eb96d5d22631c03d6aca6afa4c42f0d1295f2:228:44)

@boboci9
Copy link
Contributor

boboci9 commented Mar 3, 2015

Hi, this would mean that there will be different shipping options for products form different shops? But then shouldn't the order schema change a little to add the shipping for products from different shops? Can you tell me how this will work?
Thanks

@aaronjudd
Copy link
Contributor

Since each product should have shopId, we should be able to get shipping, taxes, etc for each shop and calculate and group them together in a single checkout. I see it being a bit like Amazon checkout when items have different delivery dates etc. I don't think we need to change the order schema, but just the shipping calculation methods.

@boboci9
Copy link
Contributor

boboci9 commented Mar 3, 2015

Yes but how can the user select different shipping for each shop that he buys products from?

@aaronjudd
Copy link
Contributor

shipping and payments are now able to be split per item, per shop, in a single order. The structure has been changed to accomadate this, but the cart UI is just using the first in the array. Admin updates are in progress.

@aaronjudd aaronjudd removed the ready label Oct 8, 2015
aaronjudd added a commit that referenced this issue Dec 3, 2015
#73

- [x] editable provider (cog near method title)
- [x] add additional providers ui
aaronjudd added a commit that referenced this issue Dec 3, 2015
 *  Fixes #244
 *  Fixes #243
 *  Fixes #122
 *  Refinements for Issue
#73
 *  Updates state-machine v2.3.5
aaronjudd added a commit that referenced this issue Dec 3, 2015
- [ x] editable provider (cog near method title)
- [ x] add additional providers ui
cmbirk pushed a commit to cmbirk/reaction that referenced this issue Aug 18, 2019
brent-hoover pushed a commit that referenced this issue Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants