Allow for disabling/overriding of search modal from a plugin #1561
Conversation
| @@ -6,8 +6,9 @@ | |||
| <div class="menu"> | |||
| {{> tagNav tagNavProps}} | |||
| </div> | |||
|
|
|||
| <div class="search">{{> React IconButtonComponent}}</div> | |||
| {{#if isSearchEnabled}} | |||
There was a problem hiding this comment.
Since we are still using Blaze here, why not use
{{#each reactionApps provides='ui-search' enabled=true}}
{{#each}}
(or some variation using the reactionApps helper..)
There was a problem hiding this comment.
Because I already needed to query on the db to get the template and I thought it made the code there easier to read.
There was a problem hiding this comment.
Reaction Apps returns the template, as well as i18n values and checks permissions etc.
Reaction.Apps({provides: "ui-search"}).template;
There was a problem hiding this comment.
Changed to use Reaction.Apps
|
👍 conditionally approved. The issue here is that all the components could use Reaction.Apps, not just the icon, and a shortcut registry entry for the icon. The implementation as it stand now, is just a boolean visibility, versus the ability to have multiple potential templates and display only active ones. We'll need to review this more, but @mikemurray will hit this in update the nav bar to reaction components and the template registry. |
Resolves #1399
Provide a registry setting providing "ui-search" and a template name and that will be used. Don't provide it or don't enable one? No search button.