Fix: Dashboard panel keeps re-opening during checkout

imports/plugins/core/checkout/client/index.js

@@ -15,7 +15,6 @@ import "./templates/cartPanel/cartPanel.html";
 import "./templates/cartPanel/cartPanel.js";
 
 import "./templates/checkout/addressBook/addressBook.html";
-import "./templates/checkout/addressBook/addressBook.js";
 import "./templates/checkout/completed/completed.html";
 import "./templates/checkout/completed/completed.js";
 import "./templates/checkout/header/header.html";

imports/plugins/core/checkout/client/templates/checkout/review/review.js

@@ -1,7 +1,6 @@
 import "./review.html";
 import { Meteor } from "meteor/meteor";
 import { Template } from "meteor/templating";
-import { Reaction } from "/client/api";
 
 /**
 * review status
@@ -10,9 +9,4 @@ import { Reaction } from "/client/api";
 
 Template.checkoutReview.onRendered(function () {
   Meteor.call("workflow/pushCartWorkflow", "coreCartWorkflow", "checkoutReview");
-  Reaction.showActionView({
-    name: "payment/settings",
-    provides: "settings",
-    template: "paymentSettings"
-  });
 });

imports/plugins/core/payments/client/checkout/payment/methods.js

@@ -3,29 +3,43 @@ import { Reaction } from "/client/api";
 import "./methods.html";
 
 Template.corePaymentMethods.helpers({
-  enabledPayments() {
-    const enabledPayments = [];
-    const apps = Reaction.Apps({
-      provides: "paymentMethod",
-      enabled: true
-    });
-    for (app of apps) {
-      if (app.enabled === true) enabledPayments.push(app);
-    }
-    return enabledPayments;
+  enabledPayments
+});
+
+Template.corePaymentMethods.onCreated(function () {
+  const payments = enabledPayments();
+  const paymentsEnabled = payments.length;
+  // If no payments enabled, show payments settings dashboard
+  if (!paymentsEnabled) {
+    openActionView();
   }
 });
 
 Template.corePaymentMethods.events({
   "click [data-event-action=configure-payment-methods]"(event) {
     event.preventDefault();
-
-    const dashboardRegistryEntry = Reaction.Apps({ name: "reaction-dashboard", provides: "shortcut" });
-    const paymentRegistryEntry = Reaction.Apps({ name: "reaction-payments", provides: "settings" });
-
-    Reaction.showActionView([
-      dashboardRegistryEntry[0],
-      paymentRegistryEntry[0]
-    ]);
+    openActionView();
   }
 });
+
+function enabledPayments() {
+  const enabledPaymentsArr = [];
+  const apps = Reaction.Apps({
+    provides: "paymentMethod",
+    enabled: true
+  });
+  for (app of apps) {
+    if (app.enabled === true) enabledPaymentsArr.push(app);
+  }
+  return enabledPaymentsArr;
+}
+
+function openActionView() {
+  const dashboardRegistryEntry = Reaction.Apps({ name: "reaction-dashboard", provides: "shortcut" });
+  const paymentRegistryEntry = Reaction.Apps({ name: "reaction-payments", provides: "settings" });
+
+  Reaction.showActionView([
+    dashboardRegistryEntry[0],
+    paymentRegistryEntry[0]
+  ]);
+}

imports/plugins/core/shipping/client/templates/checkout/shipping.js

@@ -47,6 +47,20 @@ Template.coreCheckoutShipping.onCreated(function () {
   this.autorun(() => {
     this.subscribe("Shipping");
   });
+
+  const shippingOpts = {
+    provides: "settings",
+    name: "settings/shipping",
+    template: "shippingSettings"
+  };
+
+  const cart = Cart.findOne();
+  const shipping = cartShippingQuotes(cart);
+  const shippingAval = shipping.length;
+  // If shipping not set, show shipping settings dashboard
+  if (!shippingAval) {
+    Reaction.showActionView(shippingOpts);
+  }
 });
 
 Template.coreCheckoutShipping.helpers({