Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1987 Panel Expander Arrow Overlapping on Dropdown #2211

Merged
merged 17 commits into from
May 11, 2017
Merged

1987 Panel Expander Arrow Overlapping on Dropdown #2211

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
f7b98ef
fix dropdown z-index
abdulsemiu-atanda May 4, 2017
9d2d69c
use z-index variable
abdulsemiu-atanda May 5, 2017
8eefb3d
Merge branch 'development' into atanda-panel-expander-issue-1987
abdulsemiu-atanda May 7, 2017
a627eb5
Merge branch 'development' into atanda-panel-expander-issue-1987
abdulsemiu-atanda May 8, 2017
c68d4af
reduce zindex-select variable value
abdulsemiu-atanda May 8, 2017
d3c63e0
Merge branch 'atanda-panel-expander-issue-1987' of https://github.com…
abdulsemiu-atanda May 8, 2017
fe29e15
override `react-select` select menu z-index
abdulsemiu-atanda May 8, 2017
d02cb1e
remove commented out style
abdulsemiu-atanda May 8, 2017
7b1a7a3
Merge branch 'development' into atanda-panel-expander-issue-1987
brent-hoover May 9, 2017
35e8ca6
fix improper variable value alignment
abdulsemiu-atanda May 9, 2017
eb7e530
Merge branch 'atanda-panel-expander-issue-1987' of https://github.com…
abdulsemiu-atanda May 9, 2017
35e02e6
Merge branch 'development' into atanda-panel-expander-issue-1987
May 9, 2017
d669b42
Merge branch 'development' into atanda-panel-expander-issue-1987
abdulsemiu-atanda May 9, 2017
a558f9a
Merge branch 'development' into atanda-panel-expander-issue-1987
brent-hoover May 11, 2017
9d3574e
move import to main.less
abdulsemiu-atanda May 11, 2017
f0420d0
Merge branch 'development' into atanda-panel-expander-issue-1987
mikemurray May 11, 2017
bf52676
Merge branch 'development' into atanda-panel-expander-issue-1987
mikemurray May 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions imports/plugins/included/default-theme/client/styles/select.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,7 @@
width: 44px;
pointer-events: none;
}

.Select-menu-outer {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe we ever start class-names with a capital letter

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it shouldn't but this class-name is generated by react-select for all the dropdowns. Hence the capital letter

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is another example of this?

z-index: 9999;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try a zindex value from the variables. Want to avoid a war of z-indicies.

in variables.less

@zindex-navbar:            1000;
@zindex-dropdown:          1000;
@zindex-popover:           1060;
@zindex-tooltip:           1070;
@zindex-navbar-fixed:      1030;
@zindex-modal-background:  1040;
@zindex-modal:             1050;

}