Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a bash script to reduce redundant configuration values #238

Merged
merged 1 commit into from
Jan 8, 2015
Merged

Conversation

prinzdezibel
Copy link
Contributor

Hi Aaron,

I propose a new shell script to reduce clutter when dealing with debug & deploy environments.

My suggestion is to have a canonical way of starting the reactioncommerce app, regardless of the environment.

With the new file it would be for development:

$ source env.sh settings/dev.sample.json
$ meteor

And for production it could be something along the lines..

$ source env.sh settings/production.sample.json
$ forever start my/bundle/main.js

Inspired by: https://www.eventedmind.com/feed/meteor-organizing-environment-variables-and-settings

Please let me know if you're interested and I would modify the source and docs. Thank you!

@aaronjudd
Copy link
Contributor

take a look in the /bin directory, there are some scripts we added a while back for this purpose. I used to use them, but haven't for a while, so they probably need some tweaking to work again. At least there might be some ideas there. BTW meteor (recently, I think) added the ability to pass the settings as METEOR_SETTINGS env variable as well.

@aaronjudd
Copy link
Contributor

I'll move this into ./bin as well.

aaronjudd pushed a commit that referenced this pull request Jan 8, 2015
Introduce a bash script to reduce redundant configuration values
@aaronjudd aaronjudd merged commit b85d71c into reactioncommerce:v0.2.2 Jan 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants