[Marketplace] Orders line items refund

[joykare]

Resolves #2377

Notes

• Include shipping option doesn't work as of now coz there isn't a way to have separate shipping costs for individual line items

What to test

• The whole invoice card (Converted most of this into react) Make sure it works/looks as it did before
• The line items popover:
  Designs
  https://app.zeplin.io/project/58af8900737c137280322bd6/screen/59360096eecad57cedd7c9a2
  https://app.zeplin.io/project/58af8900737c137280322bd6/screen/5936009418216793598a3118
  https://app.zeplin.io/project/58af8900737c137280322bd6/screen/5936009344d012c633a30693

How to test

• Clone branch
• Log in as an admin
• Make an order with more than 2 items (of the same variant) on your cart
• Navigate to orders dashboard

Part 1:

• Make sure invoice card works as it did before
• Approve, Capture and apply refund to make sure it still works

Part 2:

• Select a line item
• Note popover opens
• Edit line items to return some of the items ordered
• Go over designs to make sure workflow matches
• Check order on mongo billing.paymentMethod/status should be partialRefund
• Select all items for refund and refund.
• Check order on mongo billing.paymentMethod/status should be refunded

[brent-hoover]

@joykare Did you deal with the issue of not bubbling up errors from the API? I think that is the only blocker I had left.

[joykare]

@zenweasel the bubbling issue is fixed now.

Notes

• At the moment changing the email sent
• For now renaming all the variables named return... to refunds

[Update] Since the email issue involves creating a new template for emails sent after refunding items, I think it best to have it in a separate ticket. Thoughts on this are very welcome @spencern @rymorgan. I've added TODOs in the code in the meantime.

Sidenote --> I also noticed, the normal refund email doesn't show refund amount. (Adding a new ticket for this)

[spencern]

@joykare Are we not just updating copy on the existing return/refund email template? What new template do you need to create?

[joykare]

Was hoping to have the mailing in a new ticket, have this ticket merged first and hop onto that ticket. But if its critical for this ticket then I will do it here.

[Update] @spencern Email template done and uploaded.

[aaronjudd]

Shippo + PayPal Express. Need to test with and safely check all payment types.

meteor.js?hash=814eae5b938a9a89ce7cf9174c98be4982f953d8:934 TypeError: Cannot read property 'support' of undefined
    at InvoiceContainer.hasRefundingEnabled (invoiceContainer.js:224)
    at InvoiceContainer.render (invoiceContainer.js:468)
    at modules.js?hash=034804c2473433a2e9b78c99244a582259ad3f15:108666
    at measureLifeCyclePerf (modules.js?hash=034804c2473433a2e9b78c99244a582259ad3f15:107946)
    at ReactCompositeComponentWrapper._renderValidatedComponentWithoutOwnerOrContext (modules.js?hash=034804c2473433a2e9b78c99244a582259ad3f15:108665)
    at ReactCompositeComponentWrapper._renderValidatedComponent (modules.js?hash=034804c2473433a2e9b78c99244a582259ad3f15:108692)
    at ReactCompositeComponentWrapper.performInitialMount (modules.js?hash=034804c2473433a2e9b78c99244a582259ad3f15:108232)
    at ReactCompositeComponentWrapper.mountComponent (modules.js?hash=034804c2473433a2e9b78c99244a582259ad3f15:108128)
    at Object.mountComponent (modules.js?hash=034804c2473433a2e9b78c99244a582259ad3f15:100889)
    at ReactCompositeComponentWrapper.performInitialMount (modules.js?hash=034804c2473433a2e9b78c99244a582259ad3f15:108241)
meteor.js?hash=814eae5b938a9a89ce7cf9174c98be4982f953d8:934 Exception from Tracker recompute function:
meteor.js?hash=814eae5b938a9a89ce7cf9174c98be4982f953d8:934 TypeError: Cannot read property '_currentElement' of null
    at ReactCompositeComponentWrapper._updateRenderedComponent (modules.js?hash=034804c2473433a2e9b78c99244a582259ad3f15:108615)
    at ReactCompositeComponentWrapper._performComponentUpdate (modules.js?hash=034804c2473433a2e9b78c99244a582259ad3f15:108594)
    at ReactCompositeComponentWrapper.updateComponent (modules.js?hash=034804c2473433a2e9b78c99244a582259ad3f15:108515)
    at ReactCompositeComponentWrapper.receiveComponent (modules.js?hash=034804c2473433a2e9b78c99244a582259ad3f15:108417)
    at Object.receiveComponent (modules.js?hash=034804c2473433a2e9b78c99244a582259ad3f15:100968)
    at ReactCompositeComponentWrapper._updateRenderedComponent (modules.js?hash=034804c2473433a2e9b78c99244a582259ad3f15:108624)
    at ReactCompositeComponentWrapper._performComponentUpdate (modules.js?hash=034804c2473433a2e9b78c99244a582259ad3f15:108594)
    at ReactCompositeComponentWrapper.updateComponent (modules.js?hash=034804c2473433a2e9b78c99244a582259ad3f15:108515)
    at ReactCompositeComponentWrapper.performUpdateIfNecessary (modules.js?hash=034804c2473433a2e9b78c99244a582259ad3f15:108431)
    at Object.performUpdateIfNecessary (modules.js?hash=034804c2473433a2e9b78c99244a582259ad3f15:101000)

[aaronjudd]

Please test with all payment providers.

[joykare]

@aaronjudd the issue with hasRefundingEnabled wasnt introduced by this PR. There is a ticket to fix it (created by you). Checkout #2705

[aaronjudd]

@joykare I've assigned #2705 to you then and I consider it to be a critical impact blocker for the release of marketplace. Seems to me, in reviewing, it should be a very quick fix.

[spencern]

@joykare I found a few more uses of "return" instead of "refund" but I went ahead and updated them so we can get this merged.

[spencern]

@zenweasel once you approve fixes for your requested changes we can go ahead and merge 🎉

[brent-hoover]

Bubbling up errors from Paypal, etc. seems to be working now