fix #2811: Cart's Limited Supply status should not hide item title/quantity info #2907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 20, 2017 10:55
…ge in the cart, along with the standard item information.
3 tasks
|
Possibly missing limited supply badge when dealing with variant options.
|
|
The limited supply label doesn't seem to cascade down the variant option. We're assuming that's always been the behavior. I'm making another issue to address that. So this one should be good to fix this bug. Made issue for the variant option behavior here: #2934 |
mikemurray
requested changes
Sep 22, 2017
| > | ||
| {handleLowInventory(item) && | ||
| <div className="badge badge-top badge-low-inv-warning"> | ||
| { i18next.t("cartDrawerItems.limitedSupply", { default: "Limited Supply" }) } |
There was a problem hiding this comment.
Prefer usage of translation component, over importing i18next where possible:
<Components.Translation i18nKey="cartDrawerItems.limitedSupply" defaultValue="Limited Supply" />
|
@machikoyasuda you've got pending request changes here |
mikemurray
approved these changes
Sep 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
# Leftbadge. It just showsLimited supplyif the Item/Variant has that on the Grid.Limited supplybadges that show up elsewhere, on the grid or the PDP.Limited SupplytoLimited supplybefore: No item title, variant title or quantity. Messed up badge.
after: brings back item title, etc. fixes badge.
