Router Performance fix to include theme in route's context #2971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… layout object by including theme in route's context
lcampanis
changed the title
|
@mikemurray can you review this one? You've got more router experience/wrote it |
spencern
requested review from
mikemurray
and removed request for
spencern and
kieckhafer
|
@spencern reviewing now. |
|
Not related to this PR, but there are some more issues with routing and grey screen logged here: #2975 Will review once routing is reliable again. |
This was referenced Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Layout's theme is now included in each route when Router initialises all routes
Router.initPackageRoutesso it can be easily included in as a body-class.Previously, in order to get the theme, the layout was refetched in each route change using
getRouteLayout()which used the same mechanics with Router for layout resolve, with fix it is now more performant.Credit @prosf