Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Fix Reaction.hasPermissions for anonymous users #3196

Closed
wants to merge 15 commits into from
Closed

[WIP] Fix Reaction.hasPermissions for anonymous users #3196

wants to merge 15 commits into from

Commits on Oct 29, 2017

  1. stop auto-appending "owner" to the permissions list of each call to h… 

    …asPermissions
    @foladipo
    foladipo committed Oct 29, 2017
    Configuration menu
    Copy the full SHA
    340bebd View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2017

  1. remove unused code

    @foladipo
    foladipo committed Oct 30, 2017
    Configuration menu
    Copy the full SHA
    34b53cf View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2017

  1. remove a proposed parameter check

    @foladipo
    foladipo committed Oct 31, 2017
    Configuration menu
    Copy the full SHA
    18ac96a View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2017

  1. remove/update some comments

    @foladipo
    foladipo committed Nov 2, 2017
    Configuration menu
    Copy the full SHA
    71402c6 View commit details
    Browse the repository at this point in the history

  2. permit owners to perform any action

    @foladipo
    foladipo committed Nov 2, 2017
    Configuration menu
    Copy the full SHA
    feb7a9c View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2017

  1. remove hard coding of 'owner' in hasPermission

    @foladipo
    foladipo committed Nov 3, 2017
    Configuration menu
    Copy the full SHA
    df09e4b View commit details
    Browse the repository at this point in the history

  2. add jsdocs to some private functions

    @foladipo
    foladipo committed Nov 3, 2017
    Configuration menu
    Copy the full SHA
    eed4b15 View commit details
    Browse the repository at this point in the history

  3. improve comments

    @foladipo
    foladipo committed Nov 3, 2017
    Configuration menu
    Copy the full SHA
    a882145 View commit details
    Browse the repository at this point in the history

  4. make all calls to hasPermission explicitly list the permissions to ch… 

    …eck for
    @foladipo
    foladipo committed Nov 3, 2017
    Configuration menu
    Copy the full SHA
    c31f384 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2017

  1. add tests for the server-side version of hasPermissions

    @foladipo
    foladipo committed Nov 14, 2017
    Configuration menu
    Copy the full SHA
    d072816 View commit details
    Browse the repository at this point in the history

  2. remove code that auto-appends 'owner' to the permissions list supplie… 

    …d to hasPermissions
    @foladipo
    foladipo committed Nov 14, 2017
    Configuration menu
    Copy the full SHA
    827daab View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2017

  1. update the jsdocs of hasPermission on both the server and the client

    @foladipo
    foladipo committed Nov 15, 2017
    Configuration menu
    Copy the full SHA
    b7c5f64 View commit details
    Browse the repository at this point in the history

  2. correct the release when some functions (in server-side hasPermission… 

    …) were added
    @foladipo
    foladipo committed Nov 15, 2017
    Configuration menu
    Copy the full SHA
    64e04cc View commit details
    Browse the repository at this point in the history

  3. improve the clarity of the description of some specs

    @foladipo
    foladipo committed Nov 15, 2017
    Configuration menu
    Copy the full SHA
    4c017c0 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2017

  1. fix failing tests

    @foladipo
    foladipo committed Nov 16, 2017
    Configuration menu
    Copy the full SHA
    b97b075 View commit details
    Browse the repository at this point in the history