Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Product url should open product detail page when user clicks on an item in the cart drawer #3758

Conversation

willopez
Copy link
Member

Resolves #3660
Impact: major
Type: bugfix

Issue

When clicking on a product in the cart drawer the corresponding product detail page is not loaded, only the URL changes.

Solution

Set the currently selected variant like this: ReactionProduct.setCurrentVariant(productItem.variants._id);
when a user clicks on a variant in the cart.

Testing

  1. Add two different variants to the cart
  2. Click on the cart icon to open the cart drawer
  3. Click on the first variant and verify that the product detail information shows the clicked variant as selected.
  4. Click on the second variant and verify that the product detail information shows the clicked variant as selected.
    More detail for what each of these sections should include are available in our Contributing Docs

Copy link
Member

@kieckhafer kieckhafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants