Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Meteor 1.7.0.3 #4368

Merged
merged 2 commits into from
Jun 27, 2018
Merged

Conversation

impactmass
Copy link
Contributor

@impactmass impactmass commented Jun 25, 2018

Resolves #4341
Impact: major
Type: fix|security

Goal

To get on latest Meteor release with Node security update.

https://github.com/meteor/meteor/blob/devel/History.md

Work

  • Update to latest base docker image to get Meteor 1.7.0.3 and Node 8.11.3
  • Run meteor update in main repo to Meteor 1.7.0.3

Testing

  • Run the app on this branch and confirm nothing breaks (e.g product creation, checkout flow)
  • Test the production Docker image generated from this branch (reactioncommerce/reaction:feat-4341-impactmass-meteor-update)

Are there other specific test steps to do when updating Meteor version? Please comment.

@impactmass impactmass changed the base branch from master to release-1.13.1 June 25, 2018 22:00
@impactmass impactmass changed the title WIP - Update to Meteor 1.7.0.3 Update to Meteor 1.7.0.3 Jun 26, 2018
@impactmass impactmass requested review from spencern and aldeed and removed request for spencern June 26, 2018 14:37
aldeed
aldeed previously requested changes Jun 26, 2018
Copy link
Contributor

@aldeed aldeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@impactmass The Node version in Dockerfile-devserver should be changed to match. That way we won't see strange differences due to different run environments.

@aldeed aldeed requested a review from willopez June 26, 2018 22:56
@aldeed
Copy link
Contributor

aldeed commented Jun 26, 2018

@willopez Can you do the testing for this since I'm out tomorrow? As long as smoke tests pass and Node version in Dockerfile-devserver gets updated, this looks good to merge to me.

@willopez
Copy link
Member

@aldeed the Dockerfile-devserver it's still at node:8.11.2 @impactmass I believe it should be updated to node:8.11.3 to match everything else.

@willopez
Copy link
Member

Thanks @impactmass

Copy link
Member

@willopez willopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passing smoke tests.

@willopez willopez merged commit 6849a9d into release-1.13.1 Jun 27, 2018
@willopez willopez deleted the feat-4341-impactmass-meteor-update branch June 27, 2018 16:17
@spencern spencern mentioned this pull request Jun 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants