Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Indicator to notify of pending product changes not yet published to catalog #4383

Merged
merged 15 commits into from
Jun 29, 2018

Conversation

kieckhafer
Copy link
Member

@kieckhafer kieckhafer commented Jun 28, 2018

Resolves #4281
Impact: minor
Type: feature

Issue

With the removal of revisions, we no long have a way to know if product data has been published to the Catalog, or if the Product collection contains updated data that has not been published.

Solution

On the PDP, we create a hash of the current data on the page, using the same functions created in #4264. We then compare this new hash to the hash saved on the product object (also created in #4264). If the hashes match, the data is consistent between the two collections. If the hashes do not match, it means there are changes waiting to be published, and we display an indicator on the Publish button.

ticket_to_anywhere_t-shirtss

Breaking changes

None.

Testing

  1. Create a new product
  2. Publish this product to the catalog
  3. Update the title (or any field that is published to the catalog)
  4. See the indicator appear on the Publish button
  5. Press the publish button
  6. See the icon change to a "loading" type indicator while the server publishes the changes
  7. See the indicator go away

@kieckhafer kieckhafer changed the title [WIP] feat: Indicator to notify of pending product changes not yet published to catalog feat: Indicator to notify of pending product changes not yet published to catalog Jun 28, 2018
@kieckhafer kieckhafer requested a review from nnnnat June 28, 2018 23:02
Copy link
Contributor

@nnnnat nnnnat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!
publishindecator

@nnnnat nnnnat merged commit 730d12a into release-1.14.0 Jun 29, 2018
@nnnnat nnnnat deleted the feat-4281-kieckhafer-productChangeIndicator branch June 29, 2018 15:27
@spencern
Copy link
Contributor

This is great! Nice work @kieckhafer

@nnnnat I'm def stealing that gif for the release notes.

@spencern spencern mentioned this pull request Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants