-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Indicator to notify of pending product changes not yet published to catalog #4383
Merged
nnnnat
merged 15 commits into
release-1.14.0
from
feat-4281-kieckhafer-productChangeIndicator
Jun 29, 2018
Merged
feat: Indicator to notify of pending product changes not yet published to catalog #4383
nnnnat
merged 15 commits into
release-1.14.0
from
feat-4281-kieckhafer-productChangeIndicator
Jun 29, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kieckhafer
changed the title
[WIP] feat: Indicator to notify of pending product changes not yet published to catalog
feat: Indicator to notify of pending product changes not yet published to catalog
Jun 28, 2018
nnnnat
approved these changes
Jun 29, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Nice work @kieckhafer @nnnnat I'm def stealing that gif for the release notes. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4281
Impact: minor
Type: feature
Issue
With the removal of revisions, we no long have a way to know if product data has been published to the
Catalog
, or if theProduct
collection contains updated data that has not been published.Solution
On the PDP, we create a hash of the current data on the page, using the same functions created in #4264. We then compare this new hash to the hash saved on the product object (also created in #4264). If the hashes match, the data is consistent between the two collections. If the hashes do not match, it means there are changes waiting to be published, and we display an indicator on the Publish button.
Breaking changes
None.
Testing
Publish
button