fix: Make bin/setup more robust to missing directories #5026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Also use bash scrict mode - Resolves #5023 Signed-off-by: Peter Lyons <[email protected]>
focusaurus
added
the
bug
manueldelreal
approved these changes
Mar 7, 2019
rosshadden
approved these changes
Mar 7, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5023
Impact: minor
Type: bugfix
Issue
findwas failing when one of its command line argument paths was not present.Solution
Remove redundant path from the
findcommand line arguments. Since we were already searching the entire current directory ("." which is the project root in this case), specifying theimports/plugins/custompath as well is unnecessary and confusing.Breaking changes
None known.
Testing
bin/setup. It should succeed.