Fix bin/setup handling bad env.example #5048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Only eval if right hand side contains a $ - Use subshell around grep || true - Sort keys Signed-off-by: Peter Lyons <[email protected]>
focusaurus
added
the
bug
rosshadden
approved these changes
Mar 18, 2019
Akarshit
approved these changes
Mar 18, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5047
Impact: minor
Type: **bugfix
Issue
A bunk
.env.examplefile can cause thebin/setupscript to abort without copying all the values into.env.Solution
$to handle dynamic env var expansiongrep || trueproperlyBreaking changes
None
Testing
.env.examplefile anywhere under yourreactiondirectory with the following lineEXAMPLE_VAR=docker.for.mac.localhost:<port>, add stuff: in networks: in docker-compose.yml./bin/setup.envfor theEXAMPLE_VARline