feat: replace reaction plugins usage
#5070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the scripts now available in this repo, which do the same thing. Signed-off-by: Eric Dobbertin <[email protected]>
|
@aldeed If this doesn't already I wonder if this could respect the settings in |
|
@zenweasel It runs the same |
focusaurus
approved these changes
Mar 27, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5036
Impact: minor
Type: chore
Issue
Reaction CLI is deprecated. We previously updated development runs to use Node scripts copied into this repo instead. Dockerfile and CircleCI had not yet been updated.
Solution
Dockerfile and CircleCI are now updated to have no remaining dependency on the Reaction CLI being installed. Actually removing the CLI from the base Docker image will be done later.
Breaking changes
None
Testing
Test a Docker build and verify that you can run the resulting image and use the API/operator UI as expected. The CircleCI config changes will be tested automatically based on tests passing on CI.