fix: catalog items performance

[mikemurray]

Resolves N/A
Impact: major
Type: performance

Issue

Catalog items query runs poorly with lots of media on variants and options.

Solution

Refactor resolver to ensure the primaryImage and media resolvers only run if requested.

Breaking changes

None.

Testing

1. Add lots of products with lots of images using a special set of data. (you know the one)
2. Run the catalogItems query with all variants and options
3. See the query fast without the primaryImage and media
4. Add the primaryImage and media and see the query slow down

{
  primaryShopId
  catalogItems(
    shopIds: ["cmVhY3Rpb24vc2hvcDpKOEJocTN1VHRkZ3daeDNyeg=="]
    tagIds:["cmVhY3Rpb24vdGFnOnRMc003SDVKSGRzWXlYZndE"]
    sortBy: createdAt,
    first: 20
  ) {
    edges {
      cursor
      node {
        _id
        ... on CatalogItemProduct {
          product {
            _id
            
            variants {
              _id
              primaryImage {
                URLs {
                  large
                  medium
                  small
                  thumbnail
                }
              }
              options {
                _id
                primaryImage {
                URLs {
                  large
                  medium
                  small
                  thumbnail
                }
            }
              }
                
          }
        }
      }
    } 
  }
}

[aldeed]

I only reviewed code, but LGTM. Good find!

[spencern]

Drastically improves performance of catalogItemsQuery by only processing media and primaryImage of options and variants that request it in the query.

[willopez]

:+1