feature: adds optional flag to filter out sold-out products #5105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Will Lopez <[email protected]>
willopez
force-pushed
the
filter-sold-out-products
branch
from
abb3292
to
a46a8c9
Compare
mikemurray
changed the title
mikemurray
requested changes
Apr 8, 2019
imports/plugins/core/catalog/server/no-meteor/queries/catalogItems.js
Outdated
Show resolved
Hide resolved
imports/plugins/core/catalog/server/no-meteor/queries/catalogItemsAggregate.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Will Lopez <[email protected]>
|
@mikemurray comments resolved. |
mikemurray
approved these changes
Apr 8, 2019
|
Tests are failing due to a security issue and should be fixed by this PR: #5108 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact: minor
Type: feature
Feature
Adds optional flag to filter out sold out products in
catalogItemsqueryTesting
isSoldOutto thecatalogItemsquery and set it to eithertrueorfalseisSoldOut=false, confirm that sold out products are not returned.