-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add landing page for catalyst #5226
feat: add landing page for catalyst #5226
Conversation
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
@rymorgan @cassytaylor just wanted to put something here so that there isn't a blank page when you first log into the Operator UI. I think this passes as a first draft of this, just to get it up there, but happy to discuss improvements if you think this needs to be changed before it's merged. |
@aldeed could you please take a look specifically at how the Route is added to the I was initially adding it using the We could add it to the very end of that array, knowing our current components that are loaded, however if someone adds a new route in the future that happens to get loaded after this one, then it would cause the same problem, which is why i did it this way. |
I'm good with this as a draft. I think in the near future we should leverage this page as an onboarding dashboard and possibly an alert center but let's give that some thought. Having it look not broken is a win. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kieckhafer I think if you add exact
prop to the Route
in the map (it's a boolean prop so just needs to be present with no value), then registering it will work. I'm guessing none of our other registered components are relying on the default partial path matching, but a quick skim should be enough to see if it broke any other routes.
https://reacttraining.com/react-router/web/api/Route/exact-bool
Signed-off-by: Erik Kieckhafer <[email protected]>
@aldeed I don't think any other components are relying on the default, I took a look and didn't' see anything. Plus the blank page... so if something was relying on it, it wasn't working anyway. Adding the |
👍 Leaving for @machikoyasuda to merge if this looks good. |
</Grid> | ||
<Grid item> | ||
<Typography align="center" variant="body2"> | ||
See our <MuiLink href="https://docs.reactioncommerce.com/docs/dashboard">Store Operator's Guide</MuiLink> for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See our <MuiLink href="https://docs.reactioncommerce.com/docs/dashboard">Store Operator's Guide</MuiLink> for more information. | |
See our <MuiLink href="https://docs.reactioncommerce.com/docs/dashboard">Store Operator’s Guide</MuiLink> for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kieckhafer Looks good! I just had this tiny tiny nitpick. If you want, I can commit this and merge it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries, I updated it, thanks for catching that! Should be ready now.
Signed-off-by: Erik Kieckhafer <[email protected]>
Impact: minor
Type: feature
Issue
When a user first lands on the Operator UI, a blank screen is shown, which makes it look broken.
Solution
Add a landing page that just lets the user know where they are, and provides links to docs, and common features.
Breaking changes
None
Testing