Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add DetailDrawer component for supplementary views #5239

Merged
merged 29 commits into from
Jun 27, 2019

Conversation

mikemurray
Copy link
Member

Resolves part of #5157
Impact: minor
Type: feature

Issue

The upcoming Orders panel updates need a Drawer/sidebar to open from the right side of the screen with additional info

Solution

Create a component that makes opening and managing a side drawer, easy and consistent.

Breaking changes

none

Testing

  1. Go to Accounts
  2. Click on Manage Groups
  3. See the drawer open.
  4. Play around with different viewport sizes, including mobile to ensure the drawer still looks good small, and doesn't overlap the primary navigation drawer.

… trailing edges of the viewport

Signed-off-by: Mike Murray <[email protected]>
… trailing edges of the viewport

Signed-off-by: Mike Murray <[email protected]>
… trailing edges of the viewport

Signed-off-by: Mike Murray <[email protected]>
…is open at mobile viewport sizes

Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
@mikemurray mikemurray changed the title [WIP] feat: Add DetailDrawer component for supplementary views feat: Add DetailDrawer component for supplementary views Jun 26, 2019
Copy link
Member

@kieckhafer kieckhafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good.

@kieckhafer kieckhafer merged commit 6cebfa6 into develop Jun 27, 2019
@kieckhafer kieckhafer deleted the feat-mikemurray-side-panel branch June 27, 2019 00:30
@jeffcorpuz jeffcorpuz mentioned this pull request Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants