Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update styling of orderCard header section, move details to sidebar #5240

Merged
merged 5 commits into from
Jun 27, 2019

Conversation

kieckhafer
Copy link
Member

Signed-off-by: Erik Kieckhafer [email protected]

Part of #5157
Impact: minor
Type: refactor

Style updates for #5157 - update the styling of the header section, and implement the new Sidebar and move some data into the sidebar.

An incremental update so #5157 isn't 100 files and 2000+ changes.

Breaking changes

None

Testing

  1. Create an order
  2. Go to order page
  3. Update URL from /order/ to /order-2.0/ to see the new read-only version
  4. See that the header area, prior to the fulfillment groups, is updated, and that the sidebar opens with Order Summary and Customer information when Show order summary is clicked

OLD:
Order_Details_for_order_reference__44000001537

NEW:
Order_Details_for_order_reference__Rxofk7DZT2kKt4rq6

@kieckhafer kieckhafer changed the title [WIP] refactor: update styling of orderCard header section, move details to sidebar refactor: update styling of orderCard header section, move details to sidebar Jun 27, 2019
@kieckhafer kieckhafer marked this pull request as ready for review June 27, 2019 03:39
Signed-off-by: Erik Kieckhafer <[email protected]>
Copy link
Member

@mikemurray mikemurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@mikemurray mikemurray merged commit d26729c into develop Jun 27, 2019
@mikemurray mikemurray deleted the feat-kieckhafer-updateReadOnlyOrderWithSidebar branch June 27, 2019 21:13
@jeffcorpuz jeffcorpuz mentioned this pull request Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants