Add forever and phantomjs to production dockerfiles #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronjudd
pushed a commit
that referenced
this pull request
Dec 2, 2015
Add forever and phantomjs to production dockerfiles
|
FYI - Forever is what we used to use, but it stopped working the the 10.x node a while back - did you test with Debian? |
|
Not sure, but perhaps we don't even need this? This type of functionality is usually built in with orchestration tools. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forever support adds about 10mb, phantomjs (which is needed for spiderable) around 40mb.
The docker build currently fails because of a bug in npm 3.4.1 but will complete again with npm 3.5.0.