-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Remove legacy social plugin, PDP, product grid and WYSIWYG code #5394
refactor: Remove legacy social plugin, PDP, product grid and WYSIWYG code #5394
Conversation
Thanks @loan-laux! Can you please take care of the DCO issues before I dive into this: https://github.com/reactioncommerce/reaction/runs/181723922 Thanks! |
Actions to take after this PR is merged:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall! Thanks for all of this @loan-laux!
One comment here about one last LESS issue, and then the DCO fix, and this should be good to merge.
imports/plugins/included/default-theme/client/styles/products/variantForm.less
Outdated
Show resolved
Hide resolved
8739a57
to
d2aba43
Compare
Signed-off-by: Loan Laux <[email protected]>
Signed-off-by: Loan Laux <[email protected]>
Signed-off-by: Loan Laux <[email protected]>
Signed-off-by: Loan Laux <[email protected]>
Signed-off-by: Loan Laux <[email protected]>
Signed-off-by: Loan Laux <[email protected]>
Signed-off-by: Loan Laux <[email protected]>
d2aba43
to
b5454a6
Compare
…loan-remove-social-plugin
Signed-off-by: Loan Laux <[email protected]>
@kieckhafer Removed the |
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Resolves #5393
Impact: major
Type: performance|refactor
Issue
First of all, the Operator UI still has a Social section, which used to serve the purpose of adding social "share" buttons on the PDP, back in the 1.x days. This is not used anymore and this feature being present in Catalyst may confuse newcomers.
Second, lots of unused code relative to the legacy PDP, the product grid and the old WYSIWYG admin is still in this repo.
Solution
We need to remove the unused parts, which will help reduce the client bundle size, improving both Catalyst and customer login UI loading times by a little bit. Not to mention a small gain in DX as well.
Breaking changes
social
plugin is no more.productDetail
ProductField
ProductTags
ProductMetadata
PriceRange
VariantList
SocialContainer
VariantListContainer
ProductNotFound
default-theme
plugin, all the CSS files under theproducts
directory were removed, with the exception ofproducts/variantForm.less
which still has literally 3 rules that are still being used.Testing
Before:
After: