ci: remove snyk as a CI task #5403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
|
@spencern This would be a great PR to merge today, as it's August 1st and it's blocking all new PRs from going in. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5327
Impact: minor
Type: ci
Issue
Snyk issues are timed randomly, with issues thrown when new bugs are reported. This could affect code we've had in the app for a while, and has nothing to do with the current PR. This causes hassle for committing code to Reaction.
Solution
Remove the CI snyk process, and rely on the daily scanned results sent to those subscribe to snyk. In the future, we can task a scheduled
snykcheck to make sure these are being taken care of.Breaking changes
None
Testing
snykdid not run in CI